From: Claudiu Manoil <claudiu.manoil@nxp.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Michael Walle <michael@walle.cc>
Subject: RE: [PATCH net-next] net: enetc: kill PHY-less mode for PFs
Date: Wed, 11 May 2022 07:28:36 +0000 [thread overview]
Message-ID: <AM9PR04MB8397286D5D10B0432D1457F296C89@AM9PR04MB8397.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20220510163950.8724-1-vladimir.oltean@nxp.com>
> -----Original Message-----
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
> Sent: Tuesday, May 10, 2022 7:40 PM
[...]
> Subject: [PATCH net-next] net: enetc: kill PHY-less mode for PFs
>
[...]
> + err = of_get_phy_mode(node, &pf->if_mode);
> + if (err) {
> + dev_err(&pdev->dev, "Failed to read PHY mode\n");
> + goto err_phy_mode;
> }
>
> + err = enetc_mdiobus_create(pf, node);
> + if (err)
> + goto err_mdiobus_create;
> +
> + err = enetc_phylink_create(priv, node);
> + if (err)
> + goto err_phylink_create;
> +
> err = register_netdev(ndev);
> if (err)
> goto err_reg_netdev;
> @@ -1296,6 +1299,7 @@ static int enetc_pf_probe(struct pci_dev *pdev,
> err_mdiobus_create:
> enetc_free_msix(priv);
> err_config_si:
> +err_phy_mode:
err_phy_mode should bail out at enetc_free_msix()
> err_alloc_msix:
> enetc_free_si_resources(priv);
> err_alloc_si_res:
> --
> 2.25.1
next prev parent reply other threads:[~2022-05-11 7:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 16:39 [PATCH net-next] net: enetc: kill PHY-less mode for PFs Vladimir Oltean
2022-05-11 7:28 ` Claudiu Manoil [this message]
2022-05-11 9:40 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM9PR04MB8397286D5D10B0432D1457F296C89@AM9PR04MB8397.eurprd04.prod.outlook.com \
--to=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.