RE: [PATCH CFT net-next] net: enetc: use .mac_select_pcs() interface

[Claudiu Manoil <claudiu.manoil@nxp.com>]

> -----Original Message-----
> From: Russell King <linux@armlinux.org.uk>
> Sent: Friday, January 7, 2022 3:41 PM
> To: David S. Miller <davem@davemloft.net>; Jakub Kicinski
> <kuba@kernel.org>
> Cc: Claudiu Manoil <claudiu.manoil@nxp.com>; netdev@vger.kernel.org
> Subject: Re: [PATCH CFT net-next] net: enetc: use .mac_select_pcs()
> interface
> 
> On Thu, Dec 16, 2021 at 12:41:41PM +0000, Russell King (Oracle) wrote:
> > Convert the PCS selection to use mac_select_pcs, which allows the PCS
> > to perform any validation it needs.
> >
> > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> 
> Hi,
> 
> Can anyone test this please? Claudiu?
> 
> Russell.
> 

Hi Russell,

drivers/net/ethernet/freescale/enetc/enetc_pf.c: In function 'enetc_pl_mac_select_pcs':
drivers/net/ethernet/freescale/enetc/enetc_pf.c:942:27: error: 'struct phylink_pcs' has no member named 'pcs'
  942 |  return pf->pcs ? &pf->pcs->pcs : NULL;

I suppose you meant:
-       return pf->pcs ? &pf->pcs->pcs : NULL;
+       return pf->pcs;

With this correction I could bring up the SGMII link on my ls1028rdb.
The patch needs also rebase.

Thanks.
Claudiu