Re: [OE-core] [PATCH] sstatesig.py: make it fatal error when sstate manifest isn't found

["Konrad Weihmann" <kweihmann@outlook.com>]

On 19.05.21 12:23, Martin Jansa wrote:
> * all known issues in this area were fixed, make it fatal that it
>    cannot be overlooked if someone triggers this issue again
> 
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>   meta/lib/oe/sstatesig.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/lib/oe/sstatesig.py b/meta/lib/oe/sstatesig.py
> index 6cd6e11acc..e86a09b332 100644
> --- a/meta/lib/oe/sstatesig.py
> +++ b/meta/lib/oe/sstatesig.py
> @@ -453,7 +453,7 @@ def find_sstate_manifest(taskdata, taskdata2, taskname, d, multilibcache):
>           manifest = d2.expand("${SSTATE_MANIFESTS}/manifest-%s-%s.%s" % (pkgarch, taskdata, taskname))
>           if os.path.exists(manifest):
>               return manifest, d2
> -    bb.error("Manifest %s not found in %s (variant '%s')?" % (manifest, d2.expand(" ".join(pkgarchs)), variant))
> +    bb.fatal("Manifest %s not found in %s (variant '%s')?" % (manifest, d2.expand(" ".join(pkgarchs)), variant))
>       return None, d2

doesn't that make the return statement obsolete? also how can an error 
be overlooked? It does make the task triggering this issue fail, so how 
is a fatal better in this case (besides abnormally terminating the task)

>   
>   def OEOuthashBasic(path, sigfile, task, d):
> 
> 
> 
> 
>