All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marko, Peter" <Peter.Marko@siemens.com>
To: "alex.kanavin@gmail.com" <alex.kanavin@gmail.com>,
	"openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Cc: "alex@linutronix.de" <alex@linutronix.de>
Subject: RE: [OE-core] [PATCH 13/21] alsa-utils-scripts: merge into alsa-utils
Date: Fri, 12 Jan 2024 09:14:55 +0000	[thread overview]
Message-ID: <AS1PR10MB5697FF2BB1A0A5CA22E34C68FD6F2@AS1PR10MB5697.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20220606120126.3381438-13-alex@linutronix.de>

Hi Alex,

I'm upgrading my layer from kirkstone to scarthgap and observed that my image failed due to gpl3 license.

I want to conveniently install whole alsa-utils except for parts where license forbids me to do it.
After your path I would need to list all alsa-utils subpackages except the scripts.
And on top of that during every core layer update I'd have to check if there is not a new one.

So from this point of view, your statement
"There is no reason to keep the recipe separate: bash dependency is not a problem until the alsa-utils-scripts package is explicitly installed into a target image."
Is not true, it's a problem for maintenance.

Would something like this be accepted when I'd submit it?
This would return alsa-utils package installation to status before your commit, while still keeping alsa-utils single recipe.

diff --git a/meta/recipes-multimedia/alsa/alsa-utils_1.2.10.bb b/meta/recipes-multimedia/alsa/alsa-utils_1.2.10.bb
index 4e5ed8dfa0..5f4048938f 100644
--- a/meta/recipes-multimedia/alsa/alsa-utils_1.2.10.bb
+++ b/meta/recipes-multimedia/alsa/alsa-utils_1.2.10.bb
@@ -56,10 +56,10 @@ ALSA_UTILS_PKGS = "\
              alsa-utils-alsactl \
              alsa-utils-alsaloop \
              alsa-utils-alsaucm \
-             alsa-utils-scripts \
              alsa-utils-nhltdmicinfo \
             "
 
+PACKAGES += "alsa-utils-scripts"
 PACKAGES += "${ALSA_UTILS_PKGS}"
 RDEPENDS:${PN} += "${ALSA_UTILS_PKGS}"

Thanks,
  Peter

-----Original Message-----
From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Alexander Kanavin via lists.openembedded.org
Sent: Monday, June 6, 2022 14:01
To: openembedded-core@lists.openembedded.org
Cc: Kanavin, Alexander (EXT) (Linutronix GmbH) <alex@linutronix.de>
Subject: [OE-core] [PATCH 13/21] alsa-utils-scripts: merge into alsa-utils

> There is no reason to keep the recipe separate: bash dependency is not a problem until the alsa-utils-scripts package is explicitly installed into a target image.
>
> Signed-off-by: Alexander Kanavin <alex@linutronix.de>
> ---


  reply	other threads:[~2024-01-12  9:15 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-06 12:01 [PATCH 01/21] sato: work around missing icons in adwaita 42.0 Alexander Kanavin
2022-06-06 12:01 ` [PATCH 02/21] adwaita-icon-theme: upgrade 41.0 -> 42.0 Alexander Kanavin
2022-06-06 12:01 ` [PATCH 03/21] less: mark upstream version as unknown Alexander Kanavin
2022-06-06 12:01 ` [PATCH 04/21] wayland: exclude pre-releases from version check Alexander Kanavin
2022-06-06 12:01 ` [PATCH 05/21] mesa-demos: update 8.4.0 -> 8.5.0 Alexander Kanavin
2022-06-06 12:01 ` [PATCH 06/21] seatd: update 0.6.4 -> 0.7.0 Alexander Kanavin
2022-06-06 12:01 ` [PATCH 07/21] systemd: update 250.5 -> 251.2 Alexander Kanavin
2022-06-06 12:01 ` [PATCH 08/21] btrfs-tools: update 5.16.2 -> 5.18 Alexander Kanavin
2022-06-06 12:01 ` [PATCH 09/21] llvm: update 14.0.3 -> 14.0.4 Alexander Kanavin
2022-06-06 12:01 ` [PATCH 10/21] python3-psutil: update 5.9.0 -> 5.9.1 Alexander Kanavin
2022-06-06 12:01 ` [PATCH 11/21] tiff: update 4.3.0 -> 4.4.0 Alexander Kanavin
2022-06-06 12:01 ` [PATCH 12/21] pulseaudio: update 15.0 -> 16.0 Alexander Kanavin
2022-06-06 12:01 ` [PATCH 13/21] alsa-utils-scripts: merge into alsa-utils Alexander Kanavin
2024-01-12  9:14   ` Marko, Peter [this message]
2024-01-12 10:41     ` [OE-core] " Alexander Kanavin
2022-06-06 12:01 ` [PATCH 14/21] alsa-utils: update 1.2.6 -> 1.2.7 Alexander Kanavin
2022-06-06 12:01 ` [PATCH 15/21] ovmf: update 202202 -> 202205 Alexander Kanavin
2022-06-06 12:01 ` [PATCH 16/21] cmake: update 3.23.1 -> 3.23.2 Alexander Kanavin
2022-06-06 12:01 ` [PATCH 17/21] ltp: upgrade 20220121 -> 20220527 Alexander Kanavin
2022-06-09  7:44   ` [OE-core] " Martin Jansa
2022-06-06 12:01 ` [PATCH 18/21] perl: update 5.34.1 -> 5.36.0 Alexander Kanavin
2022-06-09 12:44   ` [OE-core] " Martin Jansa
2022-06-09 16:20     ` Richard Purdie
2022-06-09 16:48       ` Martin Jansa
     [not found]       ` <16F701C5780AB8CB.2506@lists.openembedded.org>
2022-06-10 11:49         ` Martin Jansa
     [not found]         ` <16F74000FD1011CE.12817@lists.openembedded.org>
2022-06-10 13:14           ` Martin Jansa
2022-06-10 13:29             ` Alexander Kanavin
2022-06-10 13:37               ` Martin Jansa
2022-06-10 14:07                 ` Alexander Kanavin
2022-06-10 15:02                   ` Martin Jansa
2022-06-06 12:01 ` [PATCH 19/21] perl: drop perltoc regeneration Alexander Kanavin
2022-06-06 12:01 ` [PATCH 20/21] perl: clean prior to build Alexander Kanavin
2022-06-06 12:01 ` [PATCH 21/21] perl: enable _GNU_SOURCE define via d_gnulibc Alexander Kanavin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS1PR10MB5697FF2BB1A0A5CA22E34C68FD6F2@AS1PR10MB5697.EURPRD10.PROD.OUTLOOK.COM \
    --to=peter.marko@siemens.com \
    --cc=alex.kanavin@gmail.com \
    --cc=alex@linutronix.de \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.