From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g9t5009.houston.hpe.com (g9t5009.houston.hpe.com [15.241.48.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 48B6721157425 for ; Wed, 6 Jun 2018 16:21:02 -0700 (PDT) From: "Elliott, Robert (Persistent Memory)" Subject: RE: [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities Date: Wed, 6 Jun 2018 23:20:58 +0000 Message-ID: References: <20180521163203.26590-1-ross.zwisler@linux.intel.com> <20180521163203.26590-4-ross.zwisler@linux.intel.com> <20180605182243-mutt-send-email-mst@kernel.org> <20180605164205.GA21034@linux.intel.com> <20180605213547-mutt-send-email-mst@kernel.org> <20180605220700.GB16066@linux.intel.com> In-Reply-To: Content-Language: en-US MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: 'Dan Williams' , Ross Zwisler Cc: Eduardo Habkost , "Michael S. Tsirkin" , linux-nvdimm , Qemu Developers , Stefan Hajnoczi , Igor Mammedov List-ID: > > Okay, we can move to the symbolic names. Do you want them to be that > long, or > > would: > > > > nvdimm-cap-cpu > > nvdimm-cap-mem-ctrl > > nvdimm-cap-mirroring > > Wait, why is mirroring part of this? This data structure is intended to report any kind of platform capability, not just platform persistence capabilities. We could add a short symbolic name to the definitions in ACPI that matches the ones selected for this command line option, if that'll help people find the right names to use. I recommend mc rather than mem-ctrl to keep dashes as special. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59257) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQhjp-000100-QB for qemu-devel@nongnu.org; Wed, 06 Jun 2018 19:21:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQhjk-0004o8-QT for qemu-devel@nongnu.org; Wed, 06 Jun 2018 19:21:09 -0400 Received: from g9t5009.houston.hpe.com ([15.241.48.73]:37712) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fQhjk-0004n2-J4 for qemu-devel@nongnu.org; Wed, 06 Jun 2018 19:21:04 -0400 From: "Elliott, Robert (Persistent Memory)" Date: Wed, 6 Jun 2018 23:20:58 +0000 Message-ID: References: <20180521163203.26590-1-ross.zwisler@linux.intel.com> <20180521163203.26590-4-ross.zwisler@linux.intel.com> <20180605182243-mutt-send-email-mst@kernel.org> <20180605164205.GA21034@linux.intel.com> <20180605213547-mutt-send-email-mst@kernel.org> <20180605220700.GB16066@linux.intel.com> In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Qemu-devel] [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Dan Williams' , Ross Zwisler Cc: Eduardo Habkost , linux-nvdimm , "Michael S. Tsirkin" , Qemu Developers , Stefan Hajnoczi , Igor Mammedov > > Okay, we can move to the symbolic names. Do you want them to be that > long, or > > would: > > > > nvdimm-cap-cpu > > nvdimm-cap-mem-ctrl > > nvdimm-cap-mirroring >=20 > Wait, why is mirroring part of this? This data structure is intended to report any kind of platform capability, = not=20 just platform persistence capabilities. We could add a short symbolic name to the definitions in ACPI that matches the ones selected for this command line option, if that'll help people find the right names to use. I recommend mc rather than mem-ctrl to keep dashes as special.