From: Khem Raj <raj.khem@gmail.com>
To: Phil Blundell <pb@pbcl.net>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/9] distutils: Consider S != B case
Date: Wed, 10 Feb 2016 11:01:02 -0800 [thread overview]
Message-ID: <B1055F43-2613-4D52-B314-F9CABC755E83@gmail.com> (raw)
In-Reply-To: <1455130461.7421.130.camel@pbcl.net>
[-- Attachment #1: Type: text/plain, Size: 1329 bytes --]
> On Feb 10, 2016, at 10:54 AM, Phil Blundell <pb@pbcl.net> wrote:
>
> On Wed, 2016-02-10 at 17:43 +0000, Khem Raj wrote:
>> + cwd=$PWD;cd ${S}
>> + STAGING_INCDIR=${STAGING_INCDIR} \
>> + STAGING_LIBDIR=${STAGING_LIBDIR} \
>> + BUILD_SYS=${BUILD_SYS} HOST_SYS=${HOST_SYS} \
>> + ${STAGING_BINDIR_NATIVE}/${PYTHON_PN}-native/${PYTHON_PN} ${S}/setup.py build --build-base=${B} ${DISTUTILS_BUILD_ARGS} || \
>> + bbfatal "${PYTHON_PN} setup.py build execution failed."
>> + cd $cwd
>
> Why do you need to save and restore the cwd? If this is a shell task
> then the "cd" would be local to that shell invocation anyway, right?
>
> Also, given that you're invoking it by full pathname as
> "${S}/setup.py ..." anyway, do you even need ${S} to be the cwd in the
> first place? That seems a bit redundant.
yes however there are packages like
http://git.yoctoproject.org/cgit/cgit.cgi/meta-raspberrypi/tree/recipes-devtools/python/rpio_0.10.0.bb
and
http://git.yoctoproject.org/cgit/cgit.cgi/meta-raspberrypi/tree/recipes-devtools/python/python-rtimu_git.bb
whose build systems were assuming that they were building inside S and were referring to headers include paths
relative to source dirs.
There might be more of these kinds
>
> p.
>
>
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]
next prev parent reply other threads:[~2016-02-10 19:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 17:43 [PATCH 0/9] Upgrade uclibc/musl to latest Khem Raj
2016-02-10 17:43 ` [PATCH 1/9] distutils: Consider S != B case Khem Raj
2016-02-10 18:29 ` Richard Purdie
2016-02-10 18:53 ` Khem Raj
2016-02-10 18:54 ` Phil Blundell
2016-02-10 19:01 ` Khem Raj [this message]
2016-02-10 17:43 ` [PATCH 2/9] ltp: Upgrade to 20160126 and fix build on musl Khem Raj
2016-02-11 10:12 ` Richard Purdie
2016-02-11 16:13 ` Khem Raj
2016-02-10 17:43 ` [PATCH 3/9] musl: Upgrade to tip of tree Khem Raj
2016-02-10 17:43 ` [PATCH 4/9] uclibc-ng: Bump up to 1.0.12 release Khem Raj
2016-02-10 21:52 ` akuster808
2016-02-10 17:43 ` [PATCH 5/9] uclibc: fetch from master branch not 1.0 Khem Raj
2016-02-10 17:43 ` [PATCH 6/9] strace: build fix for MIPS + musl libc Khem Raj
2016-02-10 17:43 ` [PATCH 7/9] gdb: " Khem Raj
2016-02-10 17:43 ` [PATCH 8/9] gdb: drop unnecessary CC_FOR_BUILD etc exports Khem Raj
2016-02-10 17:43 ` [PATCH 9/9] nettle.inc: drop duplicate LIC_FILES_CHKSUM and SRC_URI hashes Khem Raj
2016-02-13 8:23 ` [PATCH 0/9] Upgrade uclibc/musl to latest Richard Purdie
2016-02-13 15:43 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B1055F43-2613-4D52-B314-F9CABC755E83@gmail.com \
--to=raj.khem@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=pb@pbcl.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.