All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adit Ranadive <aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
To: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: "dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
	<dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	pv-drivers <pv-drivers-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>,
	Bryan Tan <bryantan-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>,
	"Jorgen S. Hansen"
	<jhansen-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>,
	Aditya Sarwade <asarwade-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v1 for-rc] RDMA/vmw_pvrdma: Report CQ missed events
Date: Thu, 10 Aug 2017 21:26:06 +0000	[thread overview]
Message-ID: <B2047B7A-49AA-4899-86F9-E80039033662@vmware.com> (raw)
In-Reply-To: <20170810210103.GA9201@yuvallap>

On 8/10/17, 2:01 PM, "Yuval Shaia" <yuval.shaia@oracle.com> wrote:
> Great, i understand that.
> So, at least can you consider moving this dev_err into
> pvrdma_idx_ring_has_data so callers do not need to handle errors?

Thanks for the suggestion. It's something we will have to discuss internally,
though I'm not sure if BUG_ON is the right way to go. That just seems a really
big hammer to me.
As it stands the patch should be added since it does fix a potential race
condition.


  reply	other threads:[~2017-08-10 21:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-10 19:05 [PATCH v1 for-rc] RDMA/vmw_pvrdma: Report CQ missed events Adit Ranadive
     [not found] ` <1502391902-5674-1-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2017-08-10 20:02   ` Yuval Shaia
2017-08-10 20:55     ` Adit Ranadive
     [not found]       ` <306A2D1C-3070-4BFA-B532-D5020F5D185A-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2017-08-10 21:01         ` Yuval Shaia
2017-08-10 21:26           ` Adit Ranadive [this message]
     [not found]             ` <B2047B7A-49AA-4899-86F9-E80039033662-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2017-08-10 21:33               ` Yuval Shaia
2017-08-16 14:59                 ` Doug Ledford
     [not found]                   ` <1502895592.33760.8.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-08-30 15:31                     ` [Pv-drivers] " Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B2047B7A-49AA-4899-86F9-E80039033662@vmware.com \
    --to=aditr-pghwnbhtmq7qt0dzr+alfa@public.gmane.org \
    --cc=asarwade-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
    --cc=bryantan-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=jhansen-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=pv-drivers-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
    --cc=yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.