From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752422AbcGKWzY (ORCPT <rfc822;w@1wt.eu>);
	Mon, 11 Jul 2016 18:55:24 -0400
Received: from linuxhacker.ru ([217.76.32.60]:49338 "EHLO fiona.linuxhacker.ru"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751214AbcGKWzX convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 11 Jul 2016 18:55:23 -0400
Subject: Re: lustre sendmsg stuff
Mime-Version: 1.0 (Apple Message framework v1283)
Content-Type: text/plain; charset=us-ascii
From: Oleg Drokin <green@linuxhacker.ru>
In-Reply-To: <20160711010332.GV14480@ZenIV.linux.org.uk>
Date: Mon, 11 Jul 2016 18:54:55 -0400
Cc: James Simmons <jsimmons@infradead.org>,
        Mailing List <linux-kernel@vger.kernel.org>,
        "<linux-fsdevel@vger.kernel.org>" <linux-fsdevel@vger.kernel.org>
Content-Transfer-Encoding: 8BIT
Message-Id: <B20EAA7B-0557-4AB1-A066-7AAC68DBB579@linuxhacker.ru>
References: <FCD75A55-A1BE-48FD-8E90-E9DFFD4DFD99@linuxhacker.ru> <20160703062917.GG14480@ZenIV.linux.org.uk> <20160704000802.GH14480@ZenIV.linux.org.uk> <0145470E-667E-4A8D-AB79-F897322DA441@linuxhacker.ru> <20160704030812.GI14480@ZenIV.linux.org.uk> <1CFAE5F0-5E46-4B1D-A9EC-2D6286753A35@linuxhacker.ru> <20160705022556.GK14480@ZenIV.linux.org.uk> <88A6EDE1-10F4-48FA-BCDC-D507C3E22DFA@linuxhacker.ru> <alpine.LFD.2.20.1607101913170.6483@casper.infradead.org> <20160711010113.GU14480@ZenIV.linux.org.uk> <20160711010332.GV14480@ZenIV.linux.org.uk>
To: Al Viro <viro@ZenIV.linux.org.uk>
X-Mailer: Apple Mail (2.1283)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Jul 10, 2016, at 9:03 PM, Al Viro wrote:

> On Mon, Jul 11, 2016 at 02:01:13AM +0100, Al Viro wrote:
>> On Sun, Jul 10, 2016 at 07:14:18PM +0100, James Simmons wrote:
>> 
>>> [  111.210818]  [<ffffffffa04012bd>] kiblnd_send+0x51d/0x9e0 [ko2iblnd]
>> 
>> Mea culpa - in kiblnd_send() this
>>        if (payload_kiov)
>>                iov_iter_bvec(&from, ITER_BVEC | WRITE,
>>                                payload_kiov, payload_niov, payload_nob);
>>        else
>>                iov_iter_kvec(&from, ITER_BVEC | WRITE,
>>                                payload_iov, payload_niov, payload_nob);
>> should have s/BVEC/KVEC/ in the iov_iter_kvec() arguments.  Cut'n'paste
>> braindamage...
> 
> PS: That was introduced in the last commit in that pile - "lustre: introduce
> lnet_copy_{k,}iov2iter(), kill lnet_copy_{k,}iov2{k,}iov()".

Is this something you plan to submit to Linus or should I just submit this to
Greg along with other changes?