From: Jacob Keller <jacob.keller@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>,
"Rafael Ascensão" <rafa.almas@gmail.com>
Cc: git@vger.kernel.org, me@ikke.info, hjemli@gmail.com,
mhagger@alum.mit.edu, pclouds@gmail.com,
ilari.liusvaara@elisanet.fi
Subject: Re: [PATCH v1 2/2] log: add option to choose which refs to decorate
Date: Mon, 06 Nov 2017 12:10:40 -0800 [thread overview]
Message-ID: <B24042DB-BB27-41DE-82B7-5F3ED502D7D0@gmail.com> (raw)
In-Reply-To: <xmqq60aqn1ok.fsf@gitster.mtv.corp.google.com>
On November 3, 2017 8:49:15 PM PDT, Junio C Hamano <gitster@pobox.com> wrote:
>Rafael Ascensão <rafa.almas@gmail.com> writes:
>
>Why should this be a special case that burdens users to remember one
>more rule? Wouldn't users find "--decorate-refs=refs/tags" useful
>and it woulld be shorter and nicer than having to say "refs/tags/*"?
>
Actually, I would expect these to behave more like git describes match and exclude which don't have an extra /*. It seems natural to me that glob would always add an extra glob, but.. I don't recall if match and exlude do so.
That being said, if we think the extra glob would not cause problems and generally do what people mean... I guess consistent with --glob would be good... But it's definitely not what I'd expect at first glance.
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
next prev parent reply other threads:[~2017-11-06 20:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-04 0:41 [PATCH v1 0/2] Add option to git log to choose which refs receive decoration Rafael Ascensão
2017-11-04 0:41 ` [PATCH v1 1/2] refs: extract function to normalize partial refs Rafael Ascensão
2017-11-04 2:27 ` Junio C Hamano
2017-11-04 7:33 ` Rafael Ascensão
2017-11-04 22:45 ` Kevin Daudt
2017-11-05 13:21 ` Michael Haggerty
2017-11-05 13:42 ` Michael Haggerty
2017-11-06 1:23 ` Junio C Hamano
2017-11-06 2:37 ` Rafael Ascensão
2017-11-06 7:00 ` Michael Haggerty
2017-11-04 0:41 ` [PATCH v1 2/2] log: add option to choose which refs to decorate Rafael Ascensão
2017-11-04 3:49 ` Junio C Hamano
2017-11-04 7:34 ` Rafael Ascensão
2017-11-05 2:00 ` Junio C Hamano
2017-11-05 6:17 ` Junio C Hamano
2017-11-06 3:24 ` Rafael Ascensão
2017-11-06 3:51 ` Junio C Hamano
2017-11-06 7:09 ` Michael Haggerty
2017-11-06 20:10 ` Jacob Keller [this message]
2017-11-07 0:18 ` Junio C Hamano
2017-11-10 13:38 ` Rafael Ascensão
2017-11-10 17:42 ` Junio C Hamano
2017-11-21 21:33 ` [PATCH v2] " Rafael Ascensão
2017-11-22 4:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B24042DB-BB27-41DE-82B7-5F3ED502D7D0@gmail.com \
--to=jacob.keller@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hjemli@gmail.com \
--cc=ilari.liusvaara@elisanet.fi \
--cc=me@ikke.info \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
--cc=rafa.almas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.