From: "Yang, Wenyou" <Wenyou.Yang@atmel.com> To: Alexandre Belloni <alexandre.belloni@free-electrons.com>, Sylvain Rochet <sylvain.rochet@finsecur.com> Cc: Guenter Roeck <linux@roeck-us.net>, Boris BREZILLON <boris.brezillon@free-electrons.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Ferre, Nicolas" <Nicolas.FERRE@atmel.com>, "Desroches, Ludovic" <Ludovic.Desroches@atmel.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Wim Van Sebroeck <wim@iguana.be> Subject: RE: [PATCH 6/6] watchdog: sama5d4: try to set timeout from device tree first Date: Mon, 12 Oct 2015 08:12:42 +0000 [thread overview] Message-ID: <B256D81BAE5131468A838E5D7A243641D632216B@penmbx01> (raw) In-Reply-To: <20151012075001.GB3558@piout.net> [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset="gb2312", Size: 1395 bytes --] > -----Original Message----- > From: Alexandre Belloni [mailto:alexandre.belloni@free-electrons.com] > Sent: 2015Äê10ÔÂ12ÈÕ 15:50 > To: Sylvain Rochet > Cc: Guenter Roeck; Boris BREZILLON; linux-kernel@vger.kernel.org; Ferre, > Nicolas; Desroches, Ludovic; linux-arm-kernel@lists.infradead.org; Yang, > Wenyou; Wim Van Sebroeck > Subject: Re: [PATCH 6/6] watchdog: sama5d4: try to set timeout from device tree > first > > Hi Sylvain, > > The rest of the series looks good to me, one comment below: > > On 08/10/2015 at 23:34:34 +0200, Sylvain Rochet wrote : > > watchdog_init_timeout function doesn't try to get the "timeout-sec" DT > > property if timeout_parm is not zero. This change makes this DT > > property working for the sama5d4 watchdog driver. > > > > While I'm not sure of the feasibility, I think that the module parameter should > override the DT property. The patch should be right, the DT property overrides the module parameter. If the DT property is not a valid value, it uses the default value, initialized with the module parameter at the beginning of probe. > > -- > Alexandre Belloni, Free Electrons > Embedded Linux, Kernel and Android engineering http://free-electrons.com Best Regards, Wenyou Yang ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
WARNING: multiple messages have this Message-ID (diff)
From: Wenyou.Yang@atmel.com (Yang, Wenyou) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 6/6] watchdog: sama5d4: try to set timeout from device tree first Date: Mon, 12 Oct 2015 08:12:42 +0000 [thread overview] Message-ID: <B256D81BAE5131468A838E5D7A243641D632216B@penmbx01> (raw) In-Reply-To: <20151012075001.GB3558@piout.net> > -----Original Message----- > From: Alexandre Belloni [mailto:alexandre.belloni at free-electrons.com] > Sent: 2015?10?12? 15:50 > To: Sylvain Rochet > Cc: Guenter Roeck; Boris BREZILLON; linux-kernel at vger.kernel.org; Ferre, > Nicolas; Desroches, Ludovic; linux-arm-kernel at lists.infradead.org; Yang, > Wenyou; Wim Van Sebroeck > Subject: Re: [PATCH 6/6] watchdog: sama5d4: try to set timeout from device tree > first > > Hi Sylvain, > > The rest of the series looks good to me, one comment below: > > On 08/10/2015 at 23:34:34 +0200, Sylvain Rochet wrote : > > watchdog_init_timeout function doesn't try to get the "timeout-sec" DT > > property if timeout_parm is not zero. This change makes this DT > > property working for the sama5d4 watchdog driver. > > > > While I'm not sure of the feasibility, I think that the module parameter should > override the DT property. The patch should be right, the DT property overrides the module parameter. If the DT property is not a valid value, it uses the default value, initialized with the module parameter at the beginning of probe. > > -- > Alexandre Belloni, Free Electrons > Embedded Linux, Kernel and Android engineering http://free-electrons.com Best Regards, Wenyou Yang
next prev parent reply other threads:[~2015-10-12 8:12 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-10-08 21:34 [PATCH 0/6] watchdog: sama5d4 and at91sam9: trivial rework Sylvain Rochet 2015-10-08 21:34 ` Sylvain Rochet 2015-10-08 21:34 ` [PATCH 1/6] watchdog: at91sam9: use devm_request_irq instead of request_irq Sylvain Rochet 2015-10-08 21:34 ` Sylvain Rochet 2015-10-08 21:34 ` [PATCH 2/6] watchdog: at91sam9: use watchdog_get_drvdata instead of container_of Sylvain Rochet 2015-10-08 21:34 ` Sylvain Rochet 2015-10-08 21:34 ` [PATCH 3/6] watchdog: at91sam9: rename heartbeats into timeout where necessary Sylvain Rochet 2015-10-08 21:34 ` Sylvain Rochet 2015-10-12 10:07 ` Sylvain Rochet 2015-10-12 10:07 ` Sylvain Rochet 2015-10-08 21:34 ` [PATCH 4/6] watchdog: at91sam9: remove nowayout useless copy Sylvain Rochet 2015-10-08 21:34 ` Sylvain Rochet 2015-10-08 21:34 ` [PATCH 5/6] watchdog: at91sam9: remove unused pdata support Sylvain Rochet 2015-10-08 21:34 ` Sylvain Rochet 2015-10-08 21:34 ` [PATCH 6/6] watchdog: sama5d4: try to set timeout from device tree first Sylvain Rochet 2015-10-08 21:34 ` Sylvain Rochet 2015-10-12 7:50 ` Alexandre Belloni 2015-10-12 7:50 ` Alexandre Belloni 2015-10-12 8:12 ` Yang, Wenyou [this message] 2015-10-12 8:12 ` Yang, Wenyou 2015-10-12 13:56 ` Sylvain Rochet 2015-10-12 13:56 ` Sylvain Rochet 2015-10-12 9:09 ` Sylvain Rochet 2015-10-12 9:09 ` Sylvain Rochet
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=B256D81BAE5131468A838E5D7A243641D632216B@penmbx01 \ --to=wenyou.yang@atmel.com \ --cc=Ludovic.Desroches@atmel.com \ --cc=Nicolas.FERRE@atmel.com \ --cc=alexandre.belloni@free-electrons.com \ --cc=boris.brezillon@free-electrons.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=sylvain.rochet@finsecur.com \ --cc=wim@iguana.be \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.