From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751699AbbJLIMv (ORCPT ); Mon, 12 Oct 2015 04:12:51 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:16785 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750890AbbJLIMs (ORCPT ); Mon, 12 Oct 2015 04:12:48 -0400 From: "Yang, Wenyou" To: Alexandre Belloni , Sylvain Rochet CC: Guenter Roeck , Boris BREZILLON , "linux-kernel@vger.kernel.org" , "Ferre, Nicolas" , "Desroches, Ludovic" , "linux-arm-kernel@lists.infradead.org" , Wim Van Sebroeck Subject: RE: [PATCH 6/6] watchdog: sama5d4: try to set timeout from device tree first Thread-Topic: [PATCH 6/6] watchdog: sama5d4: try to set timeout from device tree first Thread-Index: AQHRAhEonJJ1C7aV7Uuz+IyPXSutRp5m+vOAgACJvLA= Date: Mon, 12 Oct 2015 08:12:42 +0000 Message-ID: References: <1444340074-15437-1-git-send-email-sylvain.rochet@finsecur.com> <1444340074-15437-7-git-send-email-sylvain.rochet@finsecur.com> <20151012075001.GB3558@piout.net> In-Reply-To: <20151012075001.GB3558@piout.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.168.5.13] Content-Type: text/plain; charset="gb2312" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t9C8Cto1016219 > -----Original Message----- > From: Alexandre Belloni [mailto:alexandre.belloni@free-electrons.com] > Sent: 20151012 15:50 > To: Sylvain Rochet > Cc: Guenter Roeck; Boris BREZILLON; linux-kernel@vger.kernel.org; Ferre, > Nicolas; Desroches, Ludovic; linux-arm-kernel@lists.infradead.org; Yang, > Wenyou; Wim Van Sebroeck > Subject: Re: [PATCH 6/6] watchdog: sama5d4: try to set timeout from device tree > first > > Hi Sylvain, > > The rest of the series looks good to me, one comment below: > > On 08/10/2015 at 23:34:34 +0200, Sylvain Rochet wrote : > > watchdog_init_timeout function doesn't try to get the "timeout-sec" DT > > property if timeout_parm is not zero. This change makes this DT > > property working for the sama5d4 watchdog driver. > > > > While I'm not sure of the feasibility, I think that the module parameter should > override the DT property. The patch should be right, the DT property overrides the module parameter. If the DT property is not a valid value, it uses the default value, initialized with the module parameter at the beginning of probe. > > -- > Alexandre Belloni, Free Electrons > Embedded Linux, Kernel and Android engineering http://free-electrons.com Best Regards, Wenyou Yang {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wenyou.Yang@atmel.com (Yang, Wenyou) Date: Mon, 12 Oct 2015 08:12:42 +0000 Subject: [PATCH 6/6] watchdog: sama5d4: try to set timeout from device tree first In-Reply-To: <20151012075001.GB3558@piout.net> References: <1444340074-15437-1-git-send-email-sylvain.rochet@finsecur.com> <1444340074-15437-7-git-send-email-sylvain.rochet@finsecur.com> <20151012075001.GB3558@piout.net> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > -----Original Message----- > From: Alexandre Belloni [mailto:alexandre.belloni at free-electrons.com] > Sent: 2015?10?12? 15:50 > To: Sylvain Rochet > Cc: Guenter Roeck; Boris BREZILLON; linux-kernel at vger.kernel.org; Ferre, > Nicolas; Desroches, Ludovic; linux-arm-kernel at lists.infradead.org; Yang, > Wenyou; Wim Van Sebroeck > Subject: Re: [PATCH 6/6] watchdog: sama5d4: try to set timeout from device tree > first > > Hi Sylvain, > > The rest of the series looks good to me, one comment below: > > On 08/10/2015 at 23:34:34 +0200, Sylvain Rochet wrote : > > watchdog_init_timeout function doesn't try to get the "timeout-sec" DT > > property if timeout_parm is not zero. This change makes this DT > > property working for the sama5d4 watchdog driver. > > > > While I'm not sure of the feasibility, I think that the module parameter should > override the DT property. The patch should be right, the DT property overrides the module parameter. If the DT property is not a valid value, it uses the default value, initialized with the module parameter at the beginning of probe. > > -- > Alexandre Belloni, Free Electrons > Embedded Linux, Kernel and Android engineering http://free-electrons.com Best Regards, Wenyou Yang