From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Yang, Wenyou" Subject: RE: [PATCH 2/2] can: m_can: Add CAN clock generated by UPLLCK support Date: Thu, 19 Nov 2015 04:24:59 +0000 Message-ID: References: <1447841049-5010-1-git-send-email-wenyou.yang@atmel.com> <1447841049-5010-3-git-send-email-wenyou.yang@atmel.com> <564C518A.8000501@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from eusmtp01.atmel.com ([212.144.249.243]:40363 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756164AbbKSEZF (ORCPT ); Wed, 18 Nov 2015 23:25:05 -0500 In-Reply-To: <564C518A.8000501@pengutronix.de> Content-Language: en-US Sender: linux-can-owner@vger.kernel.org List-ID: To: Marc Kleine-Budde , Wolfgang Grandegger Cc: "linux-can@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Ferre, Nicolas" SGkgTWFyYywNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBNYXJjIEts ZWluZS1CdWRkZSBbbWFpbHRvOm1rbEBwZW5ndXRyb25peC5kZV0NCj4gU2VudDogMjAxNeW5tDEx 5pyIMTjml6UgMTg6MjMNCj4gVG86IFlhbmcsIFdlbnlvdTsgV29sZmdhbmcgR3JhbmRlZ2dlcg0K PiBDYzogbGludXgtY2FuQHZnZXIua2VybmVsLm9yZzsgbmV0ZGV2QHZnZXIua2VybmVsLm9yZzsg bGludXgtDQo+IGtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IEZlcnJlLCBOaWNvbGFzDQo+IFN1Ympl Y3Q6IFJlOiBbUEFUQ0ggMi8yXSBjYW46IG1fY2FuOiBBZGQgQ0FOIGNsb2NrIGdlbmVyYXRlZCBi eSBVUExMQ0sNCj4gc3VwcG9ydA0KPiANCj4gT24gMTEvMTgvMjAxNSAxMTowNCBBTSwgV2VueW91 IFlhbmcgd3JvdGU6DQo+ID4gQXMgc2FpZCBTQU1BNUQyIGRhdGFzaGVldCwgaXQgaXMgcmVjb21t ZW5kZWQgdG8gdXNlIHRoZSBDQU4gY2xvY2sgYXQNCj4gPiBmcmVxdWVuY2llcyBvZiAyMCwgNDAg b3IgODAgTUh6LiBUbyBhY2hpZXZlIHRoZXNlIGZyZXF1ZW5jaWVzLCBQTUMNCj4gPiBHQ0szIG11 c3Qgc2VsZWN0IHRoZSBVUExMQ0soNDgwIE1IeikgYXMgc291cmNlIGNsb2NrIGFuZCBkaXZpZGUg YnkgMjQsDQo+ID4gMTIgb3IgNi4gSW4gdGhpcyBwYXRjaCB0aGUgQ0FOIGNsb2NrIGF0IDIwIE1I ei4NCj4gPg0KPiA+IEFzIGl0IGlzIGNvbmZpZ3VyZWQgdGhyb3VnaCBEVCwgaXQgZG9lc24ndCBh ZmZlY3QgdGhlIE1fQ0FOIHdpdGhvdXQNCj4gPiBjb25maWd1cmluZyBDQU4gY2xvY2sgYW5kIGl0 cyBnZW5lcmF0ZWQgY2xvY2suDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBXZW55b3UgWWFuZyA8 d2VueW91LnlhbmdAYXRtZWwuY29tPg0KPiANCj4gTkFDSw0KPiANCj4gUGxlYXNlIGRvIHRoaXMg c2V0dXAgaW4geW91ciBTb0MgY29kZSwgd2hlcmUgeW91IHNldHVwIHRoZSBjbG9jayBpbmZyYXN0 cnVjdHVyZSBvcg0KPiBoYXZlIGEgbG9vayBhdCBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu ZGluZ3MvY2xvY2svY2xvY2stYmluZGluZ3MudHh0DQo+ICJBc3NpZ25lZCBjbG9jayBwYXJlbnRz IGFuZCByYXRlcyINClRoYW5rIHlvdSBmb3IgeW91ciBhZHZpY2UuIEkgd2lsbCBkbyB0aGlzIHNl dHVwIHZpYSBEVC4NCg0KDQo+IA0KPiA+IC0tLQ0KPiA+DQo+ID4gIGRyaXZlcnMvbmV0L2Nhbi9t X2Nhbi9tX2Nhbi5jIHwgICAxNiArKysrKysrKysrKysrKystDQo+ID4gIDEgZmlsZSBjaGFuZ2Vk LCAxNSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pDQo+ID4NCj4gPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9uZXQvY2FuL21fY2FuL21fY2FuLmMNCj4gPiBiL2RyaXZlcnMvbmV0L2Nhbi9tX2Nh bi9tX2Nhbi5jIGluZGV4IGZkMWNhYTAuLjJjYTQ3ZGIgMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVy cy9uZXQvY2FuL21fY2FuL21fY2FuLmMNCj4gPiArKysgYi9kcml2ZXJzL25ldC9jYW4vbV9jYW4v bV9jYW4uYw0KPiA+IEBAIC0yNjksNiArMjY5LDggQEAgZW51bSBtX2Nhbl9tcmFtX2NmZyB7DQo+ ID4gICNkZWZpbmUgVFhfQlVGX1hURAkJQklUKDMwKQ0KPiA+ICAjZGVmaW5lIFRYX0JVRl9SVFIJ CUJJVCgyOSkNCj4gPg0KPiA+ICsjZGVmaW5lIEFUOTFfQ0FOX0NMS19GUkVRCTIwMDAwMDAwDQo+ ID4gKw0KPiA+ICAvKiBhZGRyZXNzIG9mZnNldCBhbmQgZWxlbWVudCBudW1iZXIgZm9yIGVhY2gg RklGTy9CdWZmZXIgaW4gdGhlDQo+ID4gTWVzc2FnZSBSQU0gKi8gIHN0cnVjdCBtcmFtX2NmZyB7 DQo+ID4gIAl1MTYgb2ZmOw0KPiA+IEBAIC0xMTg4LDcgKzExOTAsNyBAQCBzdGF0aWMgaW50IG1f Y2FuX3BsYXRfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZQ0KPiAqcGRldikNCj4gPiAgCXN0 cnVjdCBtX2Nhbl9wcml2ICpwcml2Ow0KPiA+ICAJc3RydWN0IHJlc291cmNlICpyZXM7DQo+ID4g IAl2b2lkIF9faW9tZW0gKmFkZHI7DQo+ID4gLQlzdHJ1Y3QgY2xrICpoY2xrLCAqY2NsazsNCj4g PiArCXN0cnVjdCBjbGsgKmhjbGssICpjY2xrLCAqdXBsbF9jbGs7DQo+ID4gIAlpbnQgaXJxLCBy ZXQ7DQo+ID4NCj4gPiAgCWhjbGsgPSBkZXZtX2Nsa19nZXQoJnBkZXYtPmRldiwgImhjbGsiKTsg QEAgLTExOTgsNiArMTIwMCwxOCBAQA0KPiA+IHN0YXRpYyBpbnQgbV9jYW5fcGxhdF9wcm9iZShz dHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQ0KPiA+ICAJCXJldHVybiAtRU5PREVWOw0KPiA+ ICAJfQ0KPiA+DQo+ID4gKwl1cGxsX2NsayA9IGRldm1fY2xrX2dldCgmcGRldi0+ZGV2LCAidXBs bGNsayIpOw0KPiA+ICsJaWYgKCFJU19FUlIodXBsbF9jbGspKSB7DQo+ID4gKwkJcmV0ID0gY2xr X3NldF9wYXJlbnQoY2NsaywgdXBsbF9jbGspOw0KPiA+ICsJCWlmICghcmV0KSB7DQo+ID4gKwkJ CXJldCA9IGNsa19zZXRfcmF0ZShjY2xrLCBBVDkxX0NBTl9DTEtfRlJFUSk7DQo+ID4gKwkJCWlm IChyZXQpIHsNCj4gPiArCQkJCWRldl9lcnIoJnBkZXYtPmRldiwgImZhaWxlZCB0byBzZXQgZ2Nr XG4iKTsNCj4gPiArCQkJCXJldHVybiAtRU5PREVWOw0KPiA+ICsJCQl9DQo+ID4gKwkJfQ0KPiA+ ICsJfQ0KPiA+ICsNCj4gPiAgCXJlcyA9IHBsYXRmb3JtX2dldF9yZXNvdXJjZV9ieW5hbWUocGRl diwgSU9SRVNPVVJDRV9NRU0sDQo+ICJtX2NhbiIpOw0KPiA+ICAJYWRkciA9IGRldm1faW9yZW1h cF9yZXNvdXJjZSgmcGRldi0+ZGV2LCByZXMpOw0KPiA+ICAJaXJxID0gcGxhdGZvcm1fZ2V0X2ly cV9ieW5hbWUocGRldiwgImludDAiKTsNCj4gPg0KPiANCj4gcmVnYXJkcywNCj4gTWFyYw0KPiAN Cj4gLS0NCj4gUGVuZ3V0cm9uaXggZS5LLiAgICAgICAgICAgICAgICAgIHwgTWFyYyBLbGVpbmUt QnVkZGUgICAgICAgICAgIHwNCj4gSW5kdXN0cmlhbCBMaW51eCBTb2x1dGlvbnMgICAgICAgIHwg UGhvbmU6ICs0OS0yMzEtMjgyNi05MjQgICAgIHwNCj4gVmVydHJldHVuZyBXZXN0L0RvcnRtdW5k ICAgICAgICAgIHwgRmF4OiAgICs0OS01MTIxLTIwNjkxNy01NTU1IHwNCj4gQW10c2dlcmljaHQg SGlsZGVzaGVpbSwgSFJBIDI2ODYgIHwgaHR0cDovL3d3dy5wZW5ndXRyb25peC5kZSAgIHwNCg0K DQpCZXN0IFJlZ2FyZHMsDQpXZW55b3UgWWFuZw0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933731AbbKSEZH (ORCPT ); Wed, 18 Nov 2015 23:25:07 -0500 Received: from eusmtp01.atmel.com ([212.144.249.243]:40363 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756164AbbKSEZF (ORCPT ); Wed, 18 Nov 2015 23:25:05 -0500 From: "Yang, Wenyou" To: Marc Kleine-Budde , Wolfgang Grandegger CC: "linux-can@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Ferre, Nicolas" Subject: RE: [PATCH 2/2] can: m_can: Add CAN clock generated by UPLLCK support Thread-Topic: [PATCH 2/2] can: m_can: Add CAN clock generated by UPLLCK support Thread-Index: AQHRIelMauNuxpQxH0qE2gKaJO7cfZ6hDEsAgAG0HlA= Date: Thu, 19 Nov 2015 04:24:59 +0000 Message-ID: References: <1447841049-5010-1-git-send-email-wenyou.yang@atmel.com> <1447841049-5010-3-git-send-email-wenyou.yang@atmel.com> <564C518A.8000501@pengutronix.de> In-Reply-To: <564C518A.8000501@pengutronix.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.168.5.13] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tAJ4PEpD023554 Hi Marc, > -----Original Message----- > From: Marc Kleine-Budde [mailto:mkl@pengutronix.de] > Sent: 2015年11月18日 18:23 > To: Yang, Wenyou; Wolfgang Grandegger > Cc: linux-can@vger.kernel.org; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; Ferre, Nicolas > Subject: Re: [PATCH 2/2] can: m_can: Add CAN clock generated by UPLLCK > support > > On 11/18/2015 11:04 AM, Wenyou Yang wrote: > > As said SAMA5D2 datasheet, it is recommended to use the CAN clock at > > frequencies of 20, 40 or 80 MHz. To achieve these frequencies, PMC > > GCK3 must select the UPLLCK(480 MHz) as source clock and divide by 24, > > 12 or 6. In this patch the CAN clock at 20 MHz. > > > > As it is configured through DT, it doesn't affect the M_CAN without > > configuring CAN clock and its generated clock. > > > > Signed-off-by: Wenyou Yang > > NACK > > Please do this setup in your SoC code, where you setup the clock infrastructure or > have a look at Documentation/devicetree/bindings/clock/clock-bindings.txt > "Assigned clock parents and rates" Thank you for your advice. I will do this setup via DT. > > > --- > > > > drivers/net/can/m_can/m_can.c | 16 +++++++++++++++- > > 1 file changed, 15 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/can/m_can/m_can.c > > b/drivers/net/can/m_can/m_can.c index fd1caa0..2ca47db 100644 > > --- a/drivers/net/can/m_can/m_can.c > > +++ b/drivers/net/can/m_can/m_can.c > > @@ -269,6 +269,8 @@ enum m_can_mram_cfg { > > #define TX_BUF_XTD BIT(30) > > #define TX_BUF_RTR BIT(29) > > > > +#define AT91_CAN_CLK_FREQ 20000000 > > + > > /* address offset and element number for each FIFO/Buffer in the > > Message RAM */ struct mram_cfg { > > u16 off; > > @@ -1188,7 +1190,7 @@ static int m_can_plat_probe(struct platform_device > *pdev) > > struct m_can_priv *priv; > > struct resource *res; > > void __iomem *addr; > > - struct clk *hclk, *cclk; > > + struct clk *hclk, *cclk, *upll_clk; > > int irq, ret; > > > > hclk = devm_clk_get(&pdev->dev, "hclk"); @@ -1198,6 +1200,18 @@ > > static int m_can_plat_probe(struct platform_device *pdev) > > return -ENODEV; > > } > > > > + upll_clk = devm_clk_get(&pdev->dev, "upllclk"); > > + if (!IS_ERR(upll_clk)) { > > + ret = clk_set_parent(cclk, upll_clk); > > + if (!ret) { > > + ret = clk_set_rate(cclk, AT91_CAN_CLK_FREQ); > > + if (ret) { > > + dev_err(&pdev->dev, "failed to set gck\n"); > > + return -ENODEV; > > + } > > + } > > + } > > + > > res = platform_get_resource_byname(pdev, IORESOURCE_MEM, > "m_can"); > > addr = devm_ioremap_resource(&pdev->dev, res); > > irq = platform_get_irq_byname(pdev, "int0"); > > > > regards, > Marc > > -- > Pengutronix e.K. | Marc Kleine-Budde | > Industrial Linux Solutions | Phone: +49-231-2826-924 | > Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | > Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | Best Regards, Wenyou Yang {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I