From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yang, Wenyou Date: Thu, 10 Dec 2015 02:15:38 +0000 Subject: [U-Boot] [PATCH v2 0/5] ARM: at91: improve peripheral and system clock handle functions In-Reply-To: <5667FBD9.4090002@denx.de> References: <1449647314-31086-1-git-send-email-wenyou.yang@atmel.com> <5667FBD9.4090002@denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Heiko, > -----Original Message----- > From: Heiko Schocher [mailto:hs at denx.de] > Sent: 2015?12?9? 18:01 > To: Yang, Wenyou > Cc: U-Boot Mailing List ; andreas.devel at googlemail.com > Subject: Re: [PATCH v2 0/5] ARM: at91: improve peripheral and system clock > handle functions > > Hello Wenyou, > > Am 09.12.2015 um 08:48 schrieb Wenyou Yang: > > To reduce the duplicated code, rework the peripheral's and system's > > clock handle functions, use these functions to replace the clock > > handle code. > > > > Changes in v2: > > - fix checkpatch warning. > > > > Wenyou Yang (5): > > ARM: at91: asm/at91_pmc.h: fix trival register offset > > ARM: at91: clock: add a new file to handle clock > > ARM: cpu: at91: clean up peripheral clock code > > board: atmel: clean up peripheral clock code > > drivers: at91: clean up peripheral clock code > > > > arch/arm/mach-at91/Makefile | 1 + > > arch/arm/mach-at91/arm920t/at91rm9200_devices.c | 13 +--- > > arch/arm/mach-at91/arm920t/timer.c | 4 +- > > arch/arm/mach-at91/arm926ejs/at91sam9260_devices.c | 36 +++------- > > arch/arm/mach-at91/arm926ejs/at91sam9261_devices.c | 28 ++------ > > arch/arm/mach-at91/arm926ejs/at91sam9263_devices.c | 37 +++------- > > .../mach-at91/arm926ejs/at91sam9m10g45_devices.c | 33 +++------ > > arch/arm/mach-at91/arm926ejs/at91sam9n12_devices.c | 40 +++-------- > > arch/arm/mach-at91/arm926ejs/at91sam9rl_devices.c | 28 ++------ > > arch/arm/mach-at91/arm926ejs/at91sam9x5_devices.c | 38 +++-------- > > arch/arm/mach-at91/arm926ejs/clock.c | 7 -- > > arch/arm/mach-at91/arm926ejs/cpu.c | 1 - > > arch/arm/mach-at91/arm926ejs/timer.c | 5 +- > > arch/arm/mach-at91/armv7/clock.c | 26 ------- > > arch/arm/mach-at91/armv7/cpu.c | 1 - > > arch/arm/mach-at91/armv7/timer.c | 1 - > > arch/arm/mach-at91/clock.c | 72 ++++++++++++++++++++ > > arch/arm/mach-at91/include/mach/at91_pmc.h | 8 +-- > > arch/arm/mach-at91/include/mach/clk.h | 2 + > > arch/arm/mach-at91/phy.c | 1 - > > arch/arm/mach-at91/sdram.c | 1 - > > board/atmel/at91rm9200ek/at91rm9200ek.c | 1 - > > board/atmel/at91rm9200ek/led.c | 5 +- > > board/atmel/at91sam9260ek/at91sam9260ek.c | 15 ++-- > > board/atmel/at91sam9261ek/at91sam9261ek.c | 8 +-- > > board/atmel/at91sam9261ek/led.c | 6 +- > > board/atmel/at91sam9263ek/at91sam9263ek.c | 23 ++----- > > board/atmel/at91sam9263ek/led.c | 9 +-- > > board/atmel/at91sam9m10g45ek/at91sam9m10g45ek.c | 20 ++---- > > board/atmel/at91sam9m10g45ek/led.c | 7 +- > > board/atmel/at91sam9n12ek/at91sam9n12ek.c | 6 +- > > board/atmel/at91sam9rlek/at91sam9rlek.c | 18 ++--- > > board/atmel/at91sam9rlek/led.c | 7 +- > > board/atmel/at91sam9x5ek/at91sam9x5ek.c | 10 +-- > > board/atmel/sama5d2_xplained/sama5d2_xplained.c | 1 - > > board/atmel/sama5d3_xplained/sama5d3_xplained.c | 5 +- > > board/atmel/sama5d3xek/sama5d3xek.c | 5 +- > > board/atmel/sama5d4_xplained/sama5d4_xplained.c | 5 +- > > board/atmel/sama5d4ek/sama5d4ek.c | 5 +- > > board/bluewater/snapper9260/snapper9260.c | 15 ++-- > > board/calao/usb_a9263/usb_a9263.c | 11 ++- > > board/egnite/ethernut5/ethernut5.c | 20 +++--- > > board/esd/meesc/meesc.c | 15 ++-- > > board/mini-box/picosam9g45/led.c | 7 +- > > board/mini-box/picosam9g45/picosam9g45.c | 17 ++--- > > board/ronetix/pm9261/led.c | 7 +- > > board/ronetix/pm9261/pm9261.c | 22 ++---- > > board/ronetix/pm9263/led.c | 7 +- > > board/ronetix/pm9263/pm9263.c | 19 ++---- > > board/ronetix/pm9g45/pm9g45.c | 20 ++---- > > board/siemens/corvus/board.c | 6 +- > > board/siemens/smartweb/smartweb.c | 3 +- > > board/siemens/taurus/taurus.c | 3 +- > > drivers/net/at91_emac.c | 9 ++- > > drivers/usb/host/ehci-atmel.c | 8 --- > > drivers/usb/host/ohci-at91.c | 20 ++---- > > 56 files changed, 252 insertions(+), 496 deletions(-) > > create mode 100644 arch/arm/mach-at91/clock.c > > I applied all your patches (the v2 versions), but now tftp does not work anymore > on the smartweb board ... > > I try to find some time to get more details ... Sorry about it. It is my fault, incorrectly used the indicator & to achieve the address of variable of pmc->pcer and pmc->pcdr. Thank you very much for your findings. > > bye, > Heiko > -- > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Best Regards, Wenyou Yang