From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753093AbcANMqN (ORCPT ); Thu, 14 Jan 2016 07:46:13 -0500 Received: from eusmtp01.atmel.com ([212.144.249.242]:47333 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750921AbcANMqL (ORCPT ); Thu, 14 Jan 2016 07:46:11 -0500 From: "Yang, Wenyou" To: Peter Korsgaard CC: Liam Girdwood , Mark Brown , "Rob Herring" , Pawel Moll , Mark Rutland , Ian Campbell , "Kumar Gala" , Krzysztof Kozlowski , "devicetree@vger.kernel.org" , "Ferre, Nicolas" , "linux-kernel@vger.kernel.org" , Javier Martinez Canillas , Lee Jones , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH v2 1/2] regulator: act8945a: add regulator driver for ACT8945A Thread-Topic: [PATCH v2 1/2] regulator: act8945a: add regulator driver for ACT8945A Thread-Index: AQHRTsC4AvId1EjgO0eIPSxqA3X3hJ769SIw Date: Thu, 14 Jan 2016 12:46:05 +0000 Message-ID: References: <1452586629-1117-1-git-send-email-wenyou.yang@atmel.com> <1452586629-1117-2-git-send-email-wenyou.yang@atmel.com> <87oacp5zl7.fsf@dell.be.48ers.dk> <87egdk39ji.fsf@dell.be.48ers.dk> <87a8o82xq3.fsf@dell.be.48ers.dk> In-Reply-To: <87a8o82xq3.fsf@dell.be.48ers.dk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.168.5.13] Content-Type: text/plain; charset="gb2312" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u0ECkIJj022561 Hi Peter, > -----Original Message----- > From: Peter Korsgaard [mailto:jacmet@gmail.com] On Behalf Of Peter Korsgaard > Sent: 2016Äê1ÔÂ14ÈÕ 19:43 > To: Yang, Wenyou > Cc: Liam Girdwood ; Mark Brown ; > Rob Herring ; Pawel Moll ; Mark > Rutland ; Ian Campbell ; > Kumar Gala ; Krzysztof Kozlowski > ; devicetree@vger.kernel.org; Ferre, Nicolas > ; linux-kernel@vger.kernel.org; Javier Martinez > Canillas ; Lee Jones ; linux-arm- > kernel@lists.infradead.org > Subject: Re: [PATCH v2 1/2] regulator: act8945a: add regulator driver for > ACT8945A > > >>>>> "Yang," == Yang, Wenyou writes: > > Hi, > > >> > >>> Isn't the regulator part of the act8945a identical to act8865? Can't we just > use >>> the existing act8865-regulator.c driver? (E.G. support 8865 variant in the > mfd >>> driver, but only register the regulator sub device?) >> >> > Yes, the > regulator part of the act8945a is identical to act8865. > >> > >> > But the act8865-regulator driver is a struct i2c_driver, and the mfd > sub- > >> device driver is a platform_driver driver, it is not easy to use > it. > >> > >> But the mfd driver could support the act8865 variant as well (by only > registering >> the regulator mfd cell). > > > I still don't understand. > > > The MFD sub device is registered as a platform device, the existing > act8865 > driver is registered as an i2c_driver. How do they match? :) > > > Could you point out which exiting driver for me to reference. Thank you! > > What I'm saying is that it isn't nice that we end up with both act8865-regulator.c > and act8954-regulator.c doing 95% the same. This can either be fixed by: > > - Adding act8865 support to your mfd driver (but only registering the > regulator subdev for act8865) and changing the existing > act8865-regulator driver to work as a mfd subdev (platform device) > > - Extending the act8865-regulator driver to register as a platform > driver in ADDITION to a i2c driver so it can be used with mfd. The > driver already uses regmap so it should only be a matter of adding the > pdev probe/remove functions. Thank you for so detail information, I will do as you said. Thanks & Best Regards, Wenyou Yang From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Yang, Wenyou" Subject: RE: [PATCH v2 1/2] regulator: act8945a: add regulator driver for ACT8945A Date: Thu, 14 Jan 2016 12:46:05 +0000 Message-ID: References: <1452586629-1117-1-git-send-email-wenyou.yang@atmel.com> <1452586629-1117-2-git-send-email-wenyou.yang@atmel.com> <87oacp5zl7.fsf@dell.be.48ers.dk> <87egdk39ji.fsf@dell.be.48ers.dk> <87a8o82xq3.fsf@dell.be.48ers.dk> Mime-Version: 1.0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <87a8o82xq3.fsf@dell.be.48ers.dk> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Peter Korsgaard Cc: Liam Girdwood , Mark Brown , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Krzysztof Kozlowski , "devicetree@vger.kernel.org" , "Ferre, Nicolas" , "linux-kernel@vger.kernel.org" , Javier Martinez Canillas , Lee Jones , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org SGkgUGV0ZXIsDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogUGV0ZXIg S29yc2dhYXJkIFttYWlsdG86amFjbWV0QGdtYWlsLmNvbV0gT24gQmVoYWxmIE9mIFBldGVyIEtv cnNnYWFyZA0KPiBTZW50OiAyMDE2xOox1MIxNMjVIDE5OjQzDQo+IFRvOiBZYW5nLCBXZW55b3Ug PFdlbnlvdS5ZYW5nQGF0bWVsLmNvbT4NCj4gQ2M6IExpYW0gR2lyZHdvb2QgPGxnaXJkd29vZEBn bWFpbC5jb20+OyBNYXJrIEJyb3duIDxicm9vbmllQGtlcm5lbC5vcmc+Ow0KPiBSb2IgSGVycmlu ZyA8cm9iaCtkdEBrZXJuZWwub3JnPjsgUGF3ZWwgTW9sbCA8cGF3ZWwubW9sbEBhcm0uY29tPjsg TWFyaw0KPiBSdXRsYW5kIDxtYXJrLnJ1dGxhbmRAYXJtLmNvbT47IElhbiBDYW1wYmVsbCA8aWpj K2RldmljZXRyZWVAaGVsbGlvbi5vcmcudWs+Ow0KPiBLdW1hciBHYWxhIDxnYWxha0Bjb2RlYXVy b3JhLm9yZz47IEtyenlzenRvZiBLb3psb3dza2kNCj4gPGsua296bG93c2tpQHNhbXN1bmcuY29t PjsgZGV2aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmc7IEZlcnJlLCBOaWNvbGFzDQo+IDxOaWNvbGFz LkZFUlJFQGF0bWVsLmNvbT47IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IEphdmllciBN YXJ0aW5leg0KPiBDYW5pbGxhcyA8amF2aWVyQGRvd2hpbGUwLm9yZz47IExlZSBKb25lcyA8bGVl LmpvbmVzQGxpbmFyby5vcmc+OyBsaW51eC1hcm0tDQo+IGtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjIgMS8yXSByZWd1bGF0b3I6IGFjdDg5NDVhOiBh ZGQgcmVndWxhdG9yIGRyaXZlciBmb3INCj4gQUNUODk0NUENCj4gDQo+ID4+Pj4+ICJZYW5nLCIg PT0gWWFuZywgV2VueW91IDxXZW55b3UuWWFuZ0BhdG1lbC5jb20+IHdyaXRlczoNCj4gDQo+IEhp LA0KPiANCj4gPj4NCj4gID4+PiBJc24ndCB0aGUgcmVndWxhdG9yIHBhcnQgb2YgdGhlIGFjdDg5 NDVhIGlkZW50aWNhbCB0byBhY3Q4ODY1PyBDYW4ndCB3ZSBqdXN0DQo+IHVzZSAgPj4+IHRoZSBl eGlzdGluZyBhY3Q4ODY1LXJlZ3VsYXRvci5jIGRyaXZlcj8gKEUuRy4gc3VwcG9ydCA4ODY1IHZh cmlhbnQgaW4gdGhlDQo+IG1mZCAgPj4+IGRyaXZlciwgYnV0IG9ubHkgcmVnaXN0ZXIgdGhlIHJl Z3VsYXRvciBzdWIgZGV2aWNlPykgID4+ICA+PiA+IFllcywgdGhlDQo+IHJlZ3VsYXRvciBwYXJ0 IG9mIHRoZSBhY3Q4OTQ1YSBpcyBpZGVudGljYWwgdG8gYWN0ODg2NS4NCj4gID4+DQo+ICA+PiA+ IEJ1dCB0aGUgYWN0ODg2NS1yZWd1bGF0b3IgZHJpdmVyIGlzIGEgc3RydWN0IGkyY19kcml2ZXIs IGFuZCB0aGUgbWZkICA+IHN1Yi0NCj4gICA+PiBkZXZpY2UgZHJpdmVyIGlzIGEgcGxhdGZvcm1f ZHJpdmVyIGRyaXZlciwgaXQgaXMgbm90IGVhc3kgdG8gdXNlICA+IGl0Lg0KPiAgPj4NCj4gID4+ IEJ1dCB0aGUgbWZkIGRyaXZlciBjb3VsZCBzdXBwb3J0IHRoZSBhY3Q4ODY1IHZhcmlhbnQgYXMg d2VsbCAoYnkgb25seQ0KPiByZWdpc3RlcmluZyAgPj4gdGhlIHJlZ3VsYXRvciBtZmQgY2VsbCku DQo+IA0KPiAgPiBJIHN0aWxsIGRvbid0IHVuZGVyc3RhbmQuDQo+IA0KPiAgPiBUaGUgTUZEIHN1 YiBkZXZpY2UgaXMgcmVnaXN0ZXJlZCBhcyBhIHBsYXRmb3JtIGRldmljZSwgdGhlIGV4aXN0aW5n ICA+IGFjdDg4NjUNCj4gZHJpdmVyIGlzIHJlZ2lzdGVyZWQgYXMgYW4gaTJjX2RyaXZlci4gSG93 IGRvIHRoZXkgbWF0Y2g/IDopDQo+IA0KPiAgPiBDb3VsZCB5b3UgcG9pbnQgb3V0IHdoaWNoIGV4 aXRpbmcgZHJpdmVyIGZvciBtZSB0byByZWZlcmVuY2UuICBUaGFuayB5b3UhDQo+IA0KPiBXaGF0 IEknbSBzYXlpbmcgaXMgdGhhdCBpdCBpc24ndCBuaWNlIHRoYXQgd2UgZW5kIHVwIHdpdGggYm90 aCBhY3Q4ODY1LXJlZ3VsYXRvci5jDQo+IGFuZCBhY3Q4OTU0LXJlZ3VsYXRvci5jIGRvaW5nIDk1 JSB0aGUgc2FtZS4gVGhpcyBjYW4gZWl0aGVyIGJlIGZpeGVkIGJ5Og0KPiANCj4gLSBBZGRpbmcg YWN0ODg2NSBzdXBwb3J0IHRvIHlvdXIgbWZkIGRyaXZlciAoYnV0IG9ubHkgcmVnaXN0ZXJpbmcg dGhlDQo+ICAgcmVndWxhdG9yIHN1YmRldiBmb3IgYWN0ODg2NSkgYW5kIGNoYW5naW5nIHRoZSBl eGlzdGluZw0KPiAgIGFjdDg4NjUtcmVndWxhdG9yIGRyaXZlciB0byB3b3JrIGFzIGEgbWZkIHN1 YmRldiAocGxhdGZvcm0gZGV2aWNlKQ0KPiANCj4gLSBFeHRlbmRpbmcgdGhlIGFjdDg4NjUtcmVn dWxhdG9yIGRyaXZlciB0byByZWdpc3RlciBhcyBhIHBsYXRmb3JtDQo+ICAgZHJpdmVyIGluIEFE RElUSU9OIHRvIGEgaTJjIGRyaXZlciBzbyBpdCBjYW4gYmUgdXNlZCB3aXRoIG1mZC4gVGhlDQo+ ICAgZHJpdmVyIGFscmVhZHkgdXNlcyByZWdtYXAgc28gaXQgc2hvdWxkIG9ubHkgYmUgYSBtYXR0 ZXIgb2YgYWRkaW5nIHRoZQ0KPiAgIHBkZXYgcHJvYmUvcmVtb3ZlIGZ1bmN0aW9ucy4NCg0KVGhh bmsgeW91IGZvciBzbyBkZXRhaWwgaW5mb3JtYXRpb24sIEkgd2lsbCBkbyBhcyB5b3Ugc2FpZC4N Cg0KDQpUaGFua3MgJiBCZXN0IFJlZ2FyZHMsDQpXZW55b3UgWWFuZw0K From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wenyou.Yang@atmel.com (Yang, Wenyou) Date: Thu, 14 Jan 2016 12:46:05 +0000 Subject: [PATCH v2 1/2] regulator: act8945a: add regulator driver for ACT8945A In-Reply-To: <87a8o82xq3.fsf@dell.be.48ers.dk> References: <1452586629-1117-1-git-send-email-wenyou.yang@atmel.com> <1452586629-1117-2-git-send-email-wenyou.yang@atmel.com> <87oacp5zl7.fsf@dell.be.48ers.dk> <87egdk39ji.fsf@dell.be.48ers.dk> <87a8o82xq3.fsf@dell.be.48ers.dk> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Peter, > -----Original Message----- > From: Peter Korsgaard [mailto:jacmet at gmail.com] On Behalf Of Peter Korsgaard > Sent: 2016?1?14? 19:43 > To: Yang, Wenyou > Cc: Liam Girdwood ; Mark Brown ; > Rob Herring ; Pawel Moll ; Mark > Rutland ; Ian Campbell ; > Kumar Gala ; Krzysztof Kozlowski > ; devicetree at vger.kernel.org; Ferre, Nicolas > ; linux-kernel at vger.kernel.org; Javier Martinez > Canillas ; Lee Jones ; linux-arm- > kernel at lists.infradead.org > Subject: Re: [PATCH v2 1/2] regulator: act8945a: add regulator driver for > ACT8945A > > >>>>> "Yang," == Yang, Wenyou writes: > > Hi, > > >> > >>> Isn't the regulator part of the act8945a identical to act8865? Can't we just > use >>> the existing act8865-regulator.c driver? (E.G. support 8865 variant in the > mfd >>> driver, but only register the regulator sub device?) >> >> > Yes, the > regulator part of the act8945a is identical to act8865. > >> > >> > But the act8865-regulator driver is a struct i2c_driver, and the mfd > sub- > >> device driver is a platform_driver driver, it is not easy to use > it. > >> > >> But the mfd driver could support the act8865 variant as well (by only > registering >> the regulator mfd cell). > > > I still don't understand. > > > The MFD sub device is registered as a platform device, the existing > act8865 > driver is registered as an i2c_driver. How do they match? :) > > > Could you point out which exiting driver for me to reference. Thank you! > > What I'm saying is that it isn't nice that we end up with both act8865-regulator.c > and act8954-regulator.c doing 95% the same. This can either be fixed by: > > - Adding act8865 support to your mfd driver (but only registering the > regulator subdev for act8865) and changing the existing > act8865-regulator driver to work as a mfd subdev (platform device) > > - Extending the act8865-regulator driver to register as a platform > driver in ADDITION to a i2c driver so it can be used with mfd. The > driver already uses regmap so it should only be a matter of adding the > pdev probe/remove functions. Thank you for so detail information, I will do as you said. Thanks & Best Regards, Wenyou Yang