All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yang, Wenyou <Wenyou.Yang@atmel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] atmel_nand: increase more delay to support MT29F32G08CBADA
Date: Mon, 25 Jan 2016 05:51:28 +0000	[thread overview]
Message-ID: <B256D81BAE5131468A838E5D7A243641D63F89B0@penmbx01> (raw)
In-Reply-To: <56A54522.6010009@googlemail.com>

Hi Andreas,

> -----Original Message-----
> From: Andreas Bie?mann [mailto:andreas.devel at googlemail.com]
> Sent: 2016?1?25? 5:42
> To: Wu, Josh <Josh.wu@atmel.com>; Scott Wood <scottwood@freescale.com>;
> U-Boot Mailing List <u-boot@lists.denx.de>
> Cc: Yang, Wenyou <Wenyou.Yang@atmel.com>; Bo Shen
> <voice.shen@gmail.com>
> Subject: Re: [PATCH 3/4] atmel_nand: increase more delay to support
> MT29F32G08CBADA
> 
> Hi Josh,
> 
> On 24.11.15 09:26, Josh Wu wrote:
> > The tR is 100us in the datasheet section: Array Characteristics
> >
> 
> I've seen 50us for tR. Which datasheet do you have?

The datasheet is downloaded from micron official website.

https://www.micron.com/parts/nand-flash/mass-storage/mt29f32g08cbadawp?pc=%7B80EFFAAD-26CB-4D06-84BC-0E3274B960A9%7D

This device requires the number of bits ECC correctability is 40 bits,

but the maximum error correction capability of PMECC IP of SAMA5D2 is 32 bits.

That is,  SAMA5D2 can't support this device.

So, I suggest to drop this patch.

> 
> Andreas
> 
> > Signed-off-by: Josh Wu <josh.wu@atmel.com>
> > ---
> >
> >  drivers/mtd/nand/atmel_nand.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mtd/nand/atmel_nand.c
> > b/drivers/mtd/nand/atmel_nand.c index 5226acf..266dfd9 100644
> > --- a/drivers/mtd/nand/atmel_nand.c
> > +++ b/drivers/mtd/nand/atmel_nand.c
> > @@ -1492,7 +1492,7 @@ int atmel_nand_chip_init(int devnum, ulong
> > base_addr)  #ifdef CONFIG_SYS_NAND_READY_PIN
> >  	nand->dev_ready = at91_nand_ready;
> >  #endif
> > -	nand->chip_delay = 75;
> > +	nand->chip_delay = 100;
> >  #ifdef CONFIG_SYS_NAND_USE_FLASH_BBT
> >  	nand->bbt_options |= NAND_BBT_USE_FLASH;  #endif
> >

Best Regards,
Wenyou Yang

  reply	other threads:[~2016-01-25  5:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-24  8:26 [U-Boot] [PATCH 0/4] atmel_nand: misc update in atmel nandflash driver Josh Wu
2015-11-24  8:26 ` [U-Boot] [PATCH 1/4] atmel_nand: use nand ecc_{strength, step}_ds instead of our own function Josh Wu
2016-01-24 21:22   ` Andreas Bießmann
2016-01-25  2:41     ` Yang, Wenyou
2015-11-24  8:26 ` [U-Boot] [PATCH 2/4] atmel_nand: add '\n' in the end of error message for better display Josh Wu
2016-01-24 21:31   ` Andreas Bießmann
2015-11-24  8:26 ` [U-Boot] [PATCH 3/4] atmel_nand: increase more delay to support MT29F32G08CBADA Josh Wu
2016-01-24 21:41   ` Andreas Bießmann
2016-01-25  5:51     ` Yang, Wenyou [this message]
2015-11-24  8:26 ` [U-Boot] [PATCH 4/4] atmel_nand: use the definition: PMECC_OOB_RESERVED_BYTES instead magic number Josh Wu
2016-01-24 21:37   ` Andreas Bießmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B256D81BAE5131468A838E5D7A243641D63F89B0@penmbx01 \
    --to=wenyou.yang@atmel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.