From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Mcnamara, John" Subject: Re: [PATCH v2 2/2] scripts: add build tests Date: Tue, 24 Nov 2015 17:49:02 +0000 Message-ID: References: <1445615606-3885-1-git-send-email-thomas.monjalon@6wind.com> <1448242808-16101-1-git-send-email-thomas.monjalon@6wind.com> <1448242808-16101-3-git-send-email-thomas.monjalon@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable To: Thomas Monjalon , "dev@dpdk.org" Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 392EC8E7E for ; Tue, 24 Nov 2015 18:49:07 +0100 (CET) In-Reply-To: <1448242808-16101-3-git-send-email-thomas.monjalon@6wind.com> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Monday, November 23, 2015 1:40 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 2/2] scripts: add build tests >=20 > ... > > +while getopts hj:q ARG ; do > + case $ARG in > + j ) J=3D$OPTARG ;; > + q ) quick=3Dtrue ;; > + h ) print_usage ; exit 0 ;; > + ? ) print_usage ; exit 1 ;; Hi John, Very useful. We should add these scripts to the contributing guide at some = point. One minor nit. "q" is used for "quick" in this script and "quiet" in the ch= eckpatch script. Maybe for consistency use "f" for fast or "n" for no-doc o= r something else. John. --=20 =20