From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [PATCH v3] doc: flow bifurcation guide on Linux
Date: Sun, 17 Jul 2016 19:31:18 +0000
Message-ID: <B27915DBBA3421428155699D51E4CFE2025A0015@IRSMSX103.ger.corp.intel.com>
References: <1466650946-22523-1-git-send-email-jingjing.wu@intel.com>
 <1468483465-29135-1-git-send-email-jingjing.wu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Liu, Yong" <yong.liu@intel.com>, "Zhang,
 Helin" <helin.zhang@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 3B0BECE7
 for <dev@dpdk.org>; Sun, 17 Jul 2016 21:31:21 +0200 (CEST)
In-Reply-To: <1468483465-29135-1-git-send-email-jingjing.wu@intel.com>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> -----Original Message-----
> From: Wu, Jingjing
> Sent: Thursday, July 14, 2016 9:04 AM
> To: Mcnamara, John <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; Wu, Jingjing <jingjing.wu@intel.com>; Liu, Yong
> <yong.liu@intel.com>; Zhang, Helin <helin.zhang@intel.com>
> Subject: [PATCH v3] doc: flow bifurcation guide on Linux
>=20
> Flow bifurcation is a mechanism which depends the advanced Ethernet devic=
e
> to split traffic between queues. It provides the capability to let the
> kernel driver and DPDK driver co-exist and take their advantages.
> It is achieved by using SRIOV and NIC's advanced filtering. This patch
> describes it and adds the user guide on ixgbe and i40 NICs.

Hi Jingjing,

Thanks for the nice clear document with clear examples and images.

Some minor comments below.

> +Other than KNI, the SW is just required to device configuration, no
> +need to take care of the packet movement during the traffic split. This
> +can get more performance with less CPU overhead.

It isn't clear here what KNIs involvement is, if any, or why it is differen=
t.
I'd suggest clarifying if it is important or just omitting otherwise.


> +.. _figure_flow_bifurcation_overview:
> +
> +.. figure:: img/flow_bifurcation_overview.*
> +
> +   Flow Bifucation Overview

s/Bifucation/Bifurcation/

Also, I'd suggest using capitalized "Flow Bifurcation" consistently through=
out the doc.

> +    .. code-block:: console
> +
> +        ethtool -K eth1 ntuple on
> +        ethtool -N eth1 flow-type udp4 src-ip 192.0.2.2 dst-ip
> 198.51.100.2 \
> +		        action $queue_index_in_VF0
> +        ethtool -N eth1 flow-type udp4 src-ip 198.51.100.2 dst-ip
> 192.0.2.2 \
> +                action $queue_index_in_VF1
> +
> +    where:
> +
> +        *   $queue_index_in_PF: [queue index]

I don't see '$queue_index_in_PF' used in this example.


> +#.  Enable and set flow filters:
> +
> +    *   L3 VEB filter, route whose dest IP =3D 192.168.50.108 to VF 0's
> queue 2.
> +
> +    .. code-block:: console
> +
> +        ethtool -N <dev_name> flow-type ip4 dst-ip 192.168.50.108 \
> +                user-def 0xffffffff00000000 action 2 loc 8
> +


I think the code-block level is wrong in these sections.

I'll send you on some other minor grammatical changes.

Thanks,

John