From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [PATCH] net/vhost: Add function to retreive
	the	'vid' for a given port id.
Date: Wed, 28 Sep 2016 16:59:03 +0000
Message-ID: <B27915DBBA3421428155699D51E4CFE2026254FC@IRSMSX103.ger.corp.intel.com>
References: <1473774463-26966-1-git-send-email-ciara.loftus@intel.com>
 <28342659.xFrdpVFeBf@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Liu, Yuanhan" <yuanhan.liu@intel.com>,
 "Richardson, Bruce" <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, "Loftus, Ciara"
 <ciara.loftus@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 2D85D2B84
 for <dev@dpdk.org>; Wed, 28 Sep 2016 18:59:19 +0200 (CEST)
In-Reply-To: <28342659.xFrdpVFeBf@xps13>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Tuesday, September 13, 2016 4:10 PM
> To: Loftus, Ciara <ciara.loftus@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/vhost: Add function to retreive the
> 'vid' for a given port id.
>=20
> 2016-09-13 14:47, Ciara Loftus:
> > In some cases when using the vHost PMD, certain vHost library
> > functions may still need to be accessed. One such example is the
> > rte_vhost_get_queue_num function which returns the number of
> > virtqueues reported by the guest - information which is not exposed by
> the PMD.
> >
> > This commit introduces a new rte_eth_vhost function that returns the
> > 'vid' associated with a given port id. This allows the PMD user to
> > call vHost library functions which require the 'vid' value.
>=20
> I think we should not add any API to the PMDs.
> Maybe you are looking for a generic API in ethdev.

Hi,

This patch got a little lost in a general discussion on generic versus spec=
ific APIs.

As far as I can see this is a PMD specific API and the general consensus by=
 the end of the thread was that this would be acceptable. Is that the case =
or are there still objections to this patch.

The patch is critical for integration of the Vhost PMD into OvS so I'd like=
 to make sure that we consider it as such. See the discussion here:

    http://openvswitch.org/pipermail/dev/2016-August/076887.html

John=20