From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Mcnamara, John" Subject: Re: [PATCH] doc: reformat crypto drivers overview Date: Thu, 23 Mar 2017 08:41:53 +0000 Message-ID: References: <1490199328-12165-1-git-send-email-pablo.de.lara.guarch@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "Trahe, Fiona" , "dev@dpdk.org" To: "De Lara Guarch, Pablo" Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 3BFBB1396 for ; Thu, 23 Mar 2017 09:41:55 +0100 (CET) In-Reply-To: <1490199328-12165-1-git-send-email-pablo.de.lara.guarch@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Wednesday, March 22, 2017 4:15 PM > To: Mcnamara, John > Cc: Trahe, Fiona ; dev@dpdk.org; De Lara Guarch, > Pablo > Subject: [PATCH] doc: reformat crypto drivers overview >=20 > Follow the approach in the network devices overview, for the feature > matrix, so it improves readibility and maintainability. >=20 There are pep8 warnings that should be fixed. Mainly for long lines: $ pep8 doc/guides/conf.py =20 doc/guides/conf.py:318:80: E501 line too long (109 > 79 characters) doc/guides/conf.py:320:80: E501 line too long (105 > 79 characters) doc/guides/conf.py:321:80: E501 line too long (81 > 79 characters) doc/guides/conf.py:322:80: E501 line too long (108 > 79 characters) doc/guides/conf.py:324:80: E501 line too long (122 > 79 characters) doc/guides/conf.py:326:80: E501 line too long (102 > 79 characters) Apart from that it is a good change and a nice generalization of the table building approach. With the above fixed: Acked-by: John McNamara