From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [PATCH v5 1/3] ethdev: new xstats API add retrieving
 by	ID
Date: Thu, 13 Apr 2017 10:52:04 +0000
Message-ID: <B27915DBBA3421428155699D51E4CFE2332B94D2@IRSMSX103.ger.corp.intel.com>
References: <1491847180-24784-2-git-send-email-jacekx.piasecki@intel.com>
 <1491928644-10383-1-git-send-email-michalx.k.jastrzebski@intel.com>
 <1491928644-10383-2-git-send-email-michalx.k.jastrzebski@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Jain, Deepak K" <deepak.k.jain@intel.com>, "Van Haaren, Harry"
 <harry.van.haaren@intel.com>, "Piasecki, JacekX" <jacekx.piasecki@intel.com>,
 "Kozak, KubaX" <kubax.kozak@intel.com>, "Kulasek, TomaszX"
 <tomaszx.kulasek@intel.com>
To: "Jastrzebski, MichalX K" <michalx.k.jastrzebski@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 4EED22986
 for <dev@dpdk.org>; Thu, 13 Apr 2017 12:52:07 +0200 (CEST)
In-Reply-To: <1491928644-10383-2-git-send-email-michalx.k.jastrzebski@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michal Jastrzebski
> Sent: Tuesday, April 11, 2017 5:37 PM
> To: dev@dpdk.org
> Cc: Jain, Deepak K <deepak.k.jain@intel.com>; Van Haaren, Harry
> <harry.van.haaren@intel.com>; Piasecki, JacekX
> <jacekx.piasecki@intel.com>; Kozak, KubaX <kubax.kozak@intel.com>;
> Kulasek, TomaszX <tomaszx.kulasek@intel.com>
> Subject: [dpdk-dev] [PATCH v5 1/3] ethdev: new xstats API add retrieving
> by ID
>=20
> From: Jacek Piasecki <jacekx.piasecki@intel.com>
>=20
> ...
>
> +Scheme for Human Readable Names
> +_______________________________
>=20
>  A naming scheme exists for the strings exposed to clients of the API.
> This is  to allow scraping of the API for statistics of interest. The
> naming scheme uses @@ -363,8 +359,8 @@ strings split by a single


Minor request, if you are updating this patchset could you use a different
title underline than ____.

The guidelines suggest:

    Level 1 Heading
    =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D


    Level 2 Heading
    ---------------


    Level 3 Heading
    ~~~~~~~~~~~~~~~


    Level 4 Heading
    ^^^^^^^^^^^^^^^

http://dpdk.org/doc/guides/contributing/documentation.html#section-headers


So in this case it should probably be ^^^^^^^^^^.

However, that is fairly minor and it is okay as is if you don't get to it.

John