From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [PATCH v6] doc: document NIC features
Date: Fri, 4 Aug 2017 11:11:05 +0000
Message-ID: <B27915DBBA3421428155699D51E4CFE23ED5AA4C@IRSMSX103.ger.corp.intel.com>
References: <20170720092303.97525-1-ferruh.yigit@intel.com>
 <46961328.cqyKbn3m1e@xps> <628b3af4-6c4e-f262-110d-f899f0422501@intel.com>
 <1557856.DY0fuUa5Sa@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, Olivier Matz <olivier.matz@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>, "Yigit, Ferruh"
 <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 8EAF62C18
 for <dev@dpdk.org>; Fri,  4 Aug 2017 13:11:09 +0200 (CEST)
In-Reply-To: <1557856.DY0fuUa5Sa@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Friday, August 4, 2017 10:32 AM
> To: Yigit, Ferruh <ferruh.yigit@intel.com>
> Cc: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>; Olivier Matz
> <olivier.matz@6wind.com>
> Subject: Re: [dpdk-dev] [PATCH v6] doc: document NIC features
>=20
> 04/08/2017 10:56, Ferruh Yigit:
> > On 8/3/2017 11:57 PM, Thomas Monjalon wrote:
> > > 01/08/2017 17:23, Ferruh Yigit:
> > >> +:orphan:
> > >> +
> > >> +.. _nic_overview_features:
> > >
> > > Why have you done an orphan page?
> > > I think it should be in doc/guides/nics/overview.rst
> >
> > There is a link from nics/overview.rst to this file. But this file is
> > not in the index and not making it orphan is causing a build warning.
>=20
> But why creating a new page?
> It could be below the table in overview.rst.

For me it makes more sense on a separate page. It isn't really overview mat=
erial.

However, thinking about it again I think that it should be included in the =
index
instead of using the :orphan: directive. Maybe after the compilation chapte=
r/page.

John