From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Mcnamara, John" Subject: Re: [PATCH 3/4] doc: Add documents for AMD XGBE Ethernet Date: Mon, 18 Sep 2017 17:39:11 +0000 Message-ID: References: <1505324838-25734-1-git-send-email-ravi1.kumar@amd.com> <1505324838-25734-3-git-send-email-ravi1.kumar@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable To: Ravi Kumar , "dev@dpdk.org" Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 33B1E4BE1 for ; Mon, 18 Sep 2017 19:39:15 +0200 (CEST) In-Reply-To: <1505324838-25734-3-git-send-email-ravi1.kumar@amd.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ravi Kumar > Sent: Wednesday, September 13, 2017 6:47 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 3/4] doc: Add documents for AMD XGBE Ethernet >=20 > Signed-off-by: Ravi Kumar Thanks for the doc. Some comments below. > ... > +.. Copyright (c) 2017 Advanced Micro Devices, Inc. > + All rights reserved. > + > + AMD 10Gb Ethernet driver > + > + This file is available to you under your choice of the following two > + licenses: > + > + License 1: GPLv2 The docs probably don't need to be dual licensed. > + > +- Jumbo Frame upto 9K s/upto/up to/ > +- Bind the intented AMD device to igb_uio module. s/intented/intended/ Also, there was a whitespace warning on the patch. Trim any trailing whitespace in the patch. Thanks. Reviewed-by: John McNamara