From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Mcnamara, John" Subject: Re: [PATCH v2] doc: add virtio lsc note Date: Thu, 12 Oct 2017 12:43:04 +0000 Message-ID: References: <20171009035616.24482-1-zhiyong.yang@intel.com> <20171010045102.11899-1-zhiyong.yang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "yliu@fridaylinux.org" , "Yigit, Ferruh" To: "Yang, Zhiyong" , "dev@dpdk.org" Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 19D351B2B3 for ; Thu, 12 Oct 2017 14:43:34 +0200 (CEST) In-Reply-To: <20171010045102.11899-1-zhiyong.yang@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yang, Zhiyong > Sent: Tuesday, October 10, 2017 5:51 AM > To: dev@dpdk.org > Cc: yliu@fridaylinux.org; Mcnamara, John ; Yigit= , > Ferruh ; Yang, Zhiyong > Subject: [PATCH v2] doc: add virtio lsc note >=20 > Virtio PMD has already supported link status change(lsc), but VM which > must be created by qemu 2.7.0 and above can support it when vhost user > disconnects, since the capability to detect vhost user disconnection is > introduced in qemu 2.7.0. The patch updates doc to let user know that. >=20 > Signed-off-by: Zhiyong Yang > --- >=20 > Changes in v2: > reword the doc and commit log. >=20 > doc/guides/nics/virtio.rst | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst inde= x > 4d6a83768..abf42dff5 100644 > --- a/doc/guides/nics/virtio.rst > +++ b/doc/guides/nics/virtio.rst > @@ -291,6 +291,11 @@ interrupt, Rx interrupts, and Tx interrupts. Config > interrupt is used for notification of device configuration changes, > especially link status (lsc). > Interrupt mode is translated into Rx interrupts in the context of DPDK. >=20 > +.. Note:: Virtio PMD has already supported to receive lsc from qemu > +when link status changes, especially when vhost user disconnects, but > +it fails to do that if VM is created by qemu 2.6.2 or below, since the > +capability to detect vhost user disconnection is introduced in qemu Hi, If you are using the Note: directive the text needs to be separated by a blank line and also indented. Otherwise it throws a doc build warning. I'd suggest something like this with some minor changes to the text included: .. Note:: Virtio PMD already has support for receiving lsc from qemu when the link status changes, especially when vhost user disconnects. However, it fail= s to do that if the VM is created by qemu 2.6.2 or below, since the capability to detect vhost user disconnection is introduced in qemu 2.7.= 0. Reviewed-by: John McNamara John