All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "Varghese, Vipin" <vipin.varghese@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Kovacevic, Marko" <marko.kovacevic@intel.com>
Subject: Re: [PATCH] doc: update the usage for shared library
Date: Tue, 6 Feb 2018 12:17:11 +0000	[thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE23EEA86BE@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1517840230-8982-1-git-send-email-vipin.varghese@intel.com>



> -----Original Message-----
> From: Varghese, Vipin
> Sent: Monday, February 5, 2018 2:17 PM
> To: dev@dpdk.org; Kovacevic, Marko <marko.kovacevic@intel.com>
> Cc: Mcnamara, John <john.mcnamara@intel.com>; Varghese, Vipin
> <vipin.varghese@intel.com>
> Subject: [PATCH] doc: update the usage for shared library
> 
> Add note information to intimate about use of option '-d' for shared
> ...
> +
> +   .. note::
> +
> +   When dpdk-testpmd is built with shared library, use option ``-d`` to
> +   load the dynamic PMD for ``rte_eal_init``.

I think the text of the note needs to be indented at least 3 spaces.

Also, the app name is testpmd, not dpdk-testpmd, right? That is what is in
the previous section of the doc.

Also, quote the application name like this: ``testpmd``.


John

  reply	other threads:[~2018-02-06 12:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-05 14:17 [PATCH] doc: update the usage for shared library Vipin Varghese
2018-02-06 12:17 ` Mcnamara, John [this message]
2018-02-06 14:09 ` [PATCH v2] " Vipin Varghese
2018-02-06 15:31   ` Mcnamara, John
2018-02-08 18:19   ` [PATCH v3] " Vipin Varghese
2018-02-09  9:19     ` Mcnamara, John
2018-02-13 23:05       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B27915DBBA3421428155699D51E4CFE23EEA86BE@IRSMSX103.ger.corp.intel.com \
    --to=john.mcnamara@intel.com \
    --cc=dev@dpdk.org \
    --cc=marko.kovacevic@intel.com \
    --cc=vipin.varghese@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.