All of
 help / color / mirror / Atom feed
From: Markus Lehtonen <>
To: Richard Purdie <>,
Subject: Re: [PATCH 2/2] data_smart: handle '\x7d' in python parsing
Date: Thu, 04 Feb 2016 08:39:25 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi Richard,

On 03/02/16 18:52, "Richard Purdie" <> wrote:

>On Wed, 2016-02-03 at 12:33 +0200, Markus Lehtonen wrote:
>> At least ncurses recipe uses a workaround (for former bitbake python
>> parser) where closing curly bracket inside a python string was
>> replaced
>> by '\x7d' ascii code. The previous "curly bracket matching" patch
>> broke
>> parsing of constructs like this as bitbake wouldn't correctly find
>> the
>> closing bracket. This patch fixes this by accepting '\x7d' as a
>> closing
>> bracket.
>> Hopefully, this patch could be reverted (and the python regexp thus
>> simplified) in the future after making sure that no recipes use the
>> '\x7d' workaround, anymore.
>> [YOCTO #8849]
>> Signed-off-by: Markus Lehtonen <>
>> ---
>>  lib/bb/ | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>To be honest, the number of recipes which do this is hopefully very
>very small and we should just go and fix them now?

I was pondering this, too, but tried to make sure not to break anything. I can e.g. grep through the layers in and and see if there are any other recipes like this and submit patches to change those.

>I'm not sure we want to go ahead and support this.

Me neither ;)


  reply	other threads:[~2016-02-04  6:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-03 10:33 [PATCH 0/2] data_smart: simple matching of curly brackets inside Python expressions Markus Lehtonen
2016-02-03 10:33 ` [PATCH 1/2] data_smart: simple bracket matching inside python expressions Markus Lehtonen
2016-02-03 15:56   ` Christopher Larson
2016-02-04  6:33     ` Markus Lehtonen
2016-02-03 10:33 ` [PATCH 2/2] data_smart: handle '\x7d' in python parsing Markus Lehtonen
2016-02-03 16:52   ` Richard Purdie
2016-02-04  6:39     ` Markus Lehtonen [this message]
2016-02-04  8:21       ` Richard Purdie
2016-02-04 17:56         ` Markus Lehtonen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.