From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mail.openembedded.org (Postfix) with ESMTP id 82540766EB for ; Thu, 4 Feb 2016 06:39:27 +0000 (UTC) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 03 Feb 2016 22:39:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,393,1449561600"; d="scan'208";a="876687239" Received: from tbniels-mobl.ger.corp.intel.com (HELO [10.252.9.212]) ([10.252.9.212]) by orsmga001.jf.intel.com with ESMTP; 03 Feb 2016 22:39:26 -0800 User-Agent: Microsoft-MacOutlook/0.0.0.151105 Date: Thu, 04 Feb 2016 08:39:25 +0200 From: Markus Lehtonen To: Richard Purdie , Message-ID: Thread-Topic: [bitbake-devel] [PATCH 2/2] data_smart: handle '\x7d' in python parsing References: <1454495619-15453-1-git-send-email-markus.lehtonen@linux.intel.com> <1454495619-15453-3-git-send-email-markus.lehtonen@linux.intel.com> <1454518366.27087.204.camel@linuxfoundation.org> In-Reply-To: <1454518366.27087.204.camel@linuxfoundation.org> Mime-version: 1.0 Subject: Re: [PATCH 2/2] data_smart: handle '\x7d' in python parsing X-BeenThere: bitbake-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussion that advance bitbake development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Feb 2016 06:39:31 -0000 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: 7bit Hi Richard, On 03/02/16 18:52, "Richard Purdie" wrote: >On Wed, 2016-02-03 at 12:33 +0200, Markus Lehtonen wrote: >> At least ncurses recipe uses a workaround (for former bitbake python >> parser) where closing curly bracket inside a python string was >> replaced >> by '\x7d' ascii code. The previous "curly bracket matching" patch >> broke >> parsing of constructs like this as bitbake wouldn't correctly find >> the >> closing bracket. This patch fixes this by accepting '\x7d' as a >> closing >> bracket. >> >> Hopefully, this patch could be reverted (and the python regexp thus >> simplified) in the future after making sure that no recipes use the >> '\x7d' workaround, anymore. >> >> [YOCTO #8849] >> >> Signed-off-by: Markus Lehtonen >> --- >> lib/bb/data_smart.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > >To be honest, the number of recipes which do this is hopefully very >very small and we should just go and fix them now? I was pondering this, too, but tried to make sure not to break anything. I can e.g. grep through the layers in git.openembedded.org and git.yoctoproject.org and see if there are any other recipes like this and submit patches to change those. >I'm not sure we want to go ahead and support this. Me neither ;) Thanks, Markus