From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 63AF820195 for ; Fri, 15 Jul 2016 17:20:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751571AbcGORUc (ORCPT ); Fri, 15 Jul 2016 13:20:32 -0400 Received: from atl4mhob03.myregisteredsite.com ([209.17.115.41]:50528 "EHLO atl4mhob03.myregisteredsite.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751286AbcGORUb convert rfc822-to-8bit (ORCPT ); Fri, 15 Jul 2016 13:20:31 -0400 Received: from mailpod.hostingplatform.com ([10.30.71.210]) by atl4mhob03.myregisteredsite.com (8.14.4/8.14.4) with ESMTP id u6FHKTKd002050 for ; Fri, 15 Jul 2016 13:20:29 -0400 Received: (qmail 21854 invoked by uid 0); 15 Jul 2016 17:20:29 -0000 X-TCPREMOTEIP: 23.28.40.196 X-Authenticated-UID: andrew@kellerfarm.com Received: from unknown (HELO ?192.168.0.195?) (andrew@kellerfarm.com@23.28.40.196) by 0 with ESMTPA; 15 Jul 2016 17:20:28 -0000 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: obsolete index in wt_status_print after pre-commit hook runs From: Andrew Keller In-Reply-To: Date: Fri, 15 Jul 2016 13:20:28 -0400 Cc: Git List Content-Transfer-Encoding: 8BIT Message-Id: References: <5988D847-25A2-4997-9601-083772689879@covenanteyes.com> To: Junio C Hamano X-Mailer: Apple Mail (2.2104) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 15.07.2016, at 1:02 nachm., Junio C Hamano wrote: > Expected outcome is an error saying "do not modify the index inside > pre-commit hook", and a rejection. It was meant as a verification > mechansim (hence it can be bypassed with --no-verify), not as a way > to make changes that the user didn't tell "git commit" to make. Ah! Good to know, then. I’ll rewrite my hook to behave more correctly. Thanks, - Andrew Keller