From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755890AbaIZOER (ORCPT ); Fri, 26 Sep 2014 10:04:17 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:55268 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755218AbaIZOEM convert rfc822-to-8bit (ORCPT ); Fri, 26 Sep 2014 10:04:12 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH 2/2] soc/fsl: add ftm alarm driver for ls1021a platform From: Kumar Gala In-Reply-To: <1411714121-32138-2-git-send-email-dongsheng.wang@freescale.com> Date: Fri, 26 Sep 2014 09:04:08 -0500 Cc: Santosh Shilimkar , Sandeep Nair , Olof Johansson , shawn.guo@linaro.org, Greg KH , Paul Walmsley , Arnd Bergmann , linux-kernel@vger.kernel.org, shawn.guo@freescale.com Content-Transfer-Encoding: 8BIT Message-Id: References: <1411714121-32138-1-git-send-email-dongsheng.wang@freescale.com> <1411714121-32138-2-git-send-email-dongsheng.wang@freescale.com> To: Dongsheng Wang X-Mailer: Apple Mail (2.1878.6) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sep 26, 2014, at 1:48 AM, Dongsheng Wang wrote: > From: Wang Dongsheng > > Only Ftm0 can be used when system going to deep sleep. So this driver > to support ftm0 as a wakeup source. > > Signed-off-by: Wang Dongsheng How does this differ from drivers/clocksource/fsl_ftm_timer.c Why not extend that with the alarm functionality you need? Also, where is the DT binding spec for this (if you plan on having a separate driver)? - k -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation