From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Huewe Subject: Re: [PATCH] Documentation: tpm: Adds the TPM device tree node documentation Date: Tue, 30 Aug 2016 01:55:53 -0700 Message-ID: References: <1472532277-21933-1-git-send-email-nayna@linux.vnet.ibm.com> <20160830063631.GA5336@intel.com> <20160830070649.GA6215@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160830070649.GA6215-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jarkko Sakkinen Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, gcwilson-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org List-Id: devicetree@vger.kernel.org Am 30. August 2016 00:06:49 GMT-07:00, schrieb Jarkko Sakkinen : >On Mon, Aug 29, 2016 at 11:41:51PM -0700, Peter Huewe wrote: >> >> >> Am 29. August 2016 23:36:31 GMT-07:00, schrieb Jarkko Sakkinen >: >> >On Tue, Aug 30, 2016 at 12:44:37AM -0400, Nayna Jain wrote: >> >> This is documenting device tree binding for >> >> I2C based TPM, similar concept which being used >> >> for virtual TPM on POWER7 and POWER8 systems running PowerVM. >> >> >> >> Signed-off-by: Nayna Jain >> >> --- >> >> Documentation/devicetree/bindings/i2c/i2c-tpm.txt | 29 >> >+++++++++++++++++++++++ >> >> 1 file changed, 29 insertions(+) >> >> create mode 100644 >Documentation/devicetree/bindings/i2c/i2c-tpm.txt >> >> >> >> diff --git a/Documentation/devicetree/bindings/i2c/i2c-tpm.txt >> >b/Documentation/devicetree/bindings/i2c/i2c-tpm.txt >> >> new file mode 100644 >> >> index 0000000..8fdee14 >> >> --- /dev/null >> >> +++ b/Documentation/devicetree/bindings/i2c/i2c-tpm.txt >> >> @@ -0,0 +1,29 @@ >> >> +Device Tree Bindings for I2C based Trusted Platform Module(TPM) >> >> +--------------------------------------------------------------- >> >> + >> >> +This node describes a TPM device connected to Processor on i2c >bus. >> >> + >> >> +Required properties: >> >> + >> >> +- compatible : 'manufacturer,model' >> >> +- label : represents device type >> >> +- linux,sml-base : base address of the Event Log. It is a >physical >> >address. >> >> + sml stands for shared memory log. >> >> +- linux,sml-size : size of the memory allocated for the Event >Log. >> >> + >> >> +Optional properties: >> >> + >> >> +- status: indicates whether the device is enabled or disabled. >> >"okay" for >> >> + enabled and "disabled" for disabled. >> >> + >> >> +Example >> >> +------- >> >> + >> >> +tpm@57 { >> >> + reg = <0x57>; >> >> + label = "tpm"; >> >> + compatible = "nuvoton,npct650", "nuvoton,npct601"; >> >> + linux,sml-base = <0x7f 0xfd450000>; >> >> + linux,sml-size = <0x10000>; >> >> + status = "okay"; >> >> +}; >> > >> >I would rather name the fields event-log-base and event-log-size. >They >> >would be much more readable and obvious names. >> >> I agree - I always get stuck upon the sml thing. >> > >> >Also, enabled should be "enabled", not "okay". >> >> No! >> okay/ok is a dt keyword! (Or at least used in everything else) >> >> It has nothing to do whether the TPM is enabled/disabled/activated >whatever >> Peter > >OK, just to educate myself, where can I find these standard keywords? See http://www.devicetree.org/specifications-pdf table 2.4 > >The granularity is wrong (section 8.7 of TPM 2.0 Structures >specification). There are four different things that you can >enabled/disable. > >/Jarkko -- Sent from my mobile ------------------------------------------------------------------------------