From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Bedia, Vaibhav" Subject: RE: how to specify dma_mask and coherent_dma_mask in hwmod Date: Thu, 28 Jun 2012 16:42:07 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:45534 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754247Ab2F1QmO convert rfc822-to-8bit (ORCPT ); Thu, 28 Jun 2012 12:42:14 -0400 In-Reply-To: Content-Language: en-US Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Paul Walmsley Cc: "N, Mugunthan V" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "Cousson, Benoit" , "Hilman, Kevin" On Thu, Jun 28, 2012 at 22:02:46, Paul Walmsley wrote: > On Thu, 28 Jun 2012, Bedia, Vaibhav wrote: > > > On Thu, Jun 28, 2012 at 21:22:54, Paul Walmsley wrote: > > [...] > > > > > > dma_mask and coherent_dma_mask can be specified during > > > device creation. See usb_musb_init() in arch/arm/mach-omap2/usb-musb.c > > > for an example. > > > > > > > Thanks for pointing this out. Should omap_device_build() start handling this > > or would that be an overkill? > > If both dma_mask and coherent_dma_mask are always 0xffffffff on all OMAPs > and we can set that safely even for devices that don't use it, then yeah > it sounds like we should set it. > I guess that's the case here also. > Care to send a patch? > Sure. Let me check with Mugunthan once. Regards, Vaibhav B. From mboxrd@z Thu Jan 1 00:00:00 1970 From: vaibhav.bedia@ti.com (Bedia, Vaibhav) Date: Thu, 28 Jun 2012 16:42:07 +0000 Subject: how to specify dma_mask and coherent_dma_mask in hwmod In-Reply-To: References: Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jun 28, 2012 at 22:02:46, Paul Walmsley wrote: > On Thu, 28 Jun 2012, Bedia, Vaibhav wrote: > > > On Thu, Jun 28, 2012 at 21:22:54, Paul Walmsley wrote: > > [...] > > > > > > dma_mask and coherent_dma_mask can be specified during > > > device creation. See usb_musb_init() in arch/arm/mach-omap2/usb-musb.c > > > for an example. > > > > > > > Thanks for pointing this out. Should omap_device_build() start handling this > > or would that be an overkill? > > If both dma_mask and coherent_dma_mask are always 0xffffffff on all OMAPs > and we can set that safely even for devices that don't use it, then yeah > it sounds like we should set it. > I guess that's the case here also. > Care to send a patch? > Sure. Let me check with Mugunthan once. Regards, Vaibhav B.