From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Bedia, Vaibhav" Subject: RE: [PATCH 04/15] ARM: OMAP2+: hwmod: Update the reset API for AM33XX Date: Tue, 6 Nov 2012 07:19:26 +0000 Message-ID: References: <1351859566-24818-1-git-send-email-vaibhav.bedia@ti.com> <1351859566-24818-5-git-send-email-vaibhav.bedia@ti.com> <5097639C.7000800@ti.com> <79CD15C6BA57404B839C016229A409A83EB635A4@DBDE01.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Return-path: Received: from arroyo.ext.ti.com ([192.94.94.40]:50612 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752068Ab2KFHTg convert rfc822-to-8bit (ORCPT ); Tue, 6 Nov 2012 02:19:36 -0500 In-Reply-To: <79CD15C6BA57404B839C016229A409A83EB635A4@DBDE01.ent.ti.com> Content-Language: en-US Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Hiremath, Vaibhav" Cc: "linux-arm-kernel@lists.infradead.org" , "linux-omap@vger.kernel.org" , "Hilman, Kevin" , "paul@pwsan.com" , "Cousson, Benoit" , "tony@atomide.com" On Tue, Nov 06, 2012 at 11:36:20, Hiremath, Vaibhav wrote: [...] > > The code is checking whether the line is already de-asserted (== 0), so I am > not sure how this will change if hardreset line is asserted during bootup. You are right. I just checked the behavior since I recall seeing something odd earlier. Looks like this is needed to avoid issues with subsequent hardreset deassertions so I'll put it back in. Regards. Vaibhav From mboxrd@z Thu Jan 1 00:00:00 1970 From: vaibhav.bedia@ti.com (Bedia, Vaibhav) Date: Tue, 6 Nov 2012 07:19:26 +0000 Subject: [PATCH 04/15] ARM: OMAP2+: hwmod: Update the reset API for AM33XX In-Reply-To: <79CD15C6BA57404B839C016229A409A83EB635A4@DBDE01.ent.ti.com> References: <1351859566-24818-1-git-send-email-vaibhav.bedia@ti.com> <1351859566-24818-5-git-send-email-vaibhav.bedia@ti.com> <5097639C.7000800@ti.com> <79CD15C6BA57404B839C016229A409A83EB635A4@DBDE01.ent.ti.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Nov 06, 2012 at 11:36:20, Hiremath, Vaibhav wrote: [...] > > The code is checking whether the line is already de-asserted (== 0), so I am > not sure how this will change if hardreset line is asserted during bootup. You are right. I just checked the behavior since I recall seeing something odd earlier. Looks like this is needed to avoid issues with subsequent hardreset deassertions so I'll put it back in. Regards. Vaibhav