All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rajashekhara, Sudhakar" <sudhakar.raj@ti.com>
To: Christian Riesch <christian.riesch@omicron.at>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"davinci-linux-open-source@linux.davincidsp.com"
	<davinci-linux-open-source@linux.davincidsp.com>,
	"Chemparathy, Cyril" <cyril@ti.com>,
	"Gole, Anant" <anantgole@ti.com>
Subject: RE: davinci_emac/mdio: SOFT_RESET of EMAC module resets MDIO on AM1808
Date: Mon, 27 Feb 2012 10:15:03 +0000	[thread overview]
Message-ID: <B6A220404B6BFC4BBD2AB91C54D39DF43177683F@DBDE01.ent.ti.com> (raw)
In-Reply-To: <1330092923-10899-1-git-send-email-christian.riesch@omicron.at>

Hi Christian,

On Fri, Feb 24, 2012 at 19:45:23, Christian Riesch wrote:
> Hello Sudhakar,
> 
> On Fri, Feb 24, 2012 at 2:02 PM, Rajashekhara, Sudhakar <sudhakar.raj@ti.com> wrote:
> > On Thu, Feb 23, 2012 at 14:39:49, Christian Riesch wrote:
> >> Hi,
> >> I observed this behavior on a Texas Instruments AM1808 SoC (AM1808
> >> experimenter's kit) running the current mainline kernel:
> >>

[snip]

> >>
> >> According to the AM1808 Technical Reference Manual (sections 18.2.14.1
> >> and 18.3.3.34 in [1]), writing a 1 to the EMAC_SOFTRESET register
> >> resets the EMAC module, but not the MDIO module. However, when I
> >> comment out the code above, the MDIO control register is not affected
> >> and the warning 'resetting idled controller' disappears.
> >>
> >
> > But this was not the case for me. Even after commenting out the above lines,
> > I could still see that MDIO was getting reset.
> 
> Uh, I am sorry. I forgot to mention that there is a second
> emac_write(EMAC_SOFTRESET,1); in emac_dev_stop() in davinci_emac.c. 
> This one must also be commented out to make the resetting idled controller 
> message go away.
> 
> The patch below shows that changes that I did. May I please ask you to try
> again with these changes?
> 

I was able to reproduce the issue. I'll debug this further and get back to you.

Regards,
Sudhakar

  reply	other threads:[~2012-02-27 10:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-23  9:09 davinci_emac/mdio: SOFT_RESET of EMAC module resets MDIO on AM1808 Christian Riesch
2012-02-23 16:06 ` Gole, Anant
2012-02-24 13:02 ` Rajashekhara, Sudhakar
2012-02-24 14:15   ` Christian Riesch
2012-02-27 10:15     ` Rajashekhara, Sudhakar [this message]
2012-02-28  5:46     ` Rajashekhara, Sudhakar
     [not found]       ` <B6A220404B6BFC4BBD2AB91C54D39DF431776D23-Er742YJ7I/eIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2012-03-12  7:04         ` Christian Riesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B6A220404B6BFC4BBD2AB91C54D39DF43177683F@DBDE01.ent.ti.com \
    --to=sudhakar.raj@ti.com \
    --cc=anantgole@ti.com \
    --cc=christian.riesch@omicron.at \
    --cc=cyril@ti.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.