From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Wang, Liang-min" <liang-min.wang@intel.com>
Subject: Re: [PATCH v17 0/5] User-space Ethtool
Date: Thu, 16 Jul 2015 22:15:01 +0000
Message-ID: <B6CB929FEBC10D4FAC4BCA7EF2298E257177E77D@FMSMSX110.amr.corp.intel.com>
References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com>
 <3483104.M20H0g0coM@xps13>
 <B6CB929FEBC10D4FAC4BCA7EF2298E257177E760@FMSMSX110.amr.corp.intel.com>
 <1922905.J0eqSKxbIu@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id E0B7F5A51
 for <dev@dpdk.org>; Fri, 17 Jul 2015 00:15:02 +0200 (CEST)
In-Reply-To: <1922905.J0eqSKxbIu@xps13>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Thomas,
	Thanks for clarification. Our next step is to create hooks on virtio and v=
mxnet3 and other ethtool op.

Thanks again for making prompt reply as I am aware it's very late in your t=
ime zone.

Larry

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, July 16, 2015 6:09 PM
> To: Wang, Liang-min
> Cc: dev@dpdk.org; O'Driscoll, Tim
> Subject: Re: [dpdk-dev] [PATCH v17 0/5] User-space Ethtool
>=20
> 2015-07-16 21:55, Wang, Liang-min:
> > Thomas,
> > 	Do you want me to create a separate patch just include the
> example/l2fwd-ethtool?
>=20
> Yes
>=20
> > 	Do you also mean besides the identified Makefiles, you see more
> rework needs to be done,
> > 	or I just need to fix Makefile issue? If just Makefile issue, I could =
try
> to make another attempt tomorrow?
>=20
> After checking the build there is probably more review to do.
> Let's take more time to have something clean and maybe more complete in
> 2.2.
> This patchset is your first contribution to DPDK and is already a nice
> achievement.
> The new API must now be implemented in more drivers to be effective.
>=20
>=20
> > > -----Original Message-----
> > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > Sent: Thursday, July 16, 2015 5:48 PM
> > > To: Wang, Liang-min
> > > Cc: dev@dpdk.org
> > > Subject: Re: [dpdk-dev] [PATCH v17 0/5] User-space Ethtool
> > >
> > > 2015-07-16 09:25, Liang-Min Larry Wang:
> > > > This implementation is designed to provide a familar interface for
> > > applications that rely on kernel-space driver to support ethtool_op a=
nd
> > > net_device_op for device management. The initial implementation
> focuses
> > > on ops that can be implemented through existing netdev APIs. More ops
> will
> > > be supported in latter release.
> > >
> > > Applied without example which needs more work, thanks
>=20