From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Wang, Xiao W" <xiao.w.wang@intel.com>
Subject: Re: [PATCH 1/2] net: fixup RARP generation
Date: Thu, 18 Jan 2018 08:53:24 +0000
Message-ID: <B7F2E978279D1D49A3034B7786DACF406F810256@SHSMSX101.ccr.corp.intel.com>
References: <20180118030921.GW29540@yliu-mob>
 <1516245283-23990-1-git-send-email-yliu@fridaylinux.org>
 <2984278.9JAyNMmhbp@xps> <20180118085105.GC29540@yliu-mob>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 Olivier Matz <olivier.matz@6wind.com>
To: Yuanhan Liu <yliu@fridaylinux.org>, Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 13A501B024
 for <dev@dpdk.org>; Thu, 18 Jan 2018 09:53:28 +0100 (CET)
In-Reply-To: <20180118085105.GC29540@yliu-mob>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Yuanhan Liu [mailto:yliu@fridaylinux.org]
> Sent: Thursday, January 18, 2018 4:51 PM
> To: Thomas Monjalon <thomas@monjalon.net>
> Cc: dev@dpdk.org; Wang, Xiao W <xiao.w.wang@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Olivier Matz <olivier.matz@6wind.com>
> Subject: Re: [dpdk-dev] [PATCH 1/2] net: fixup RARP generation
>=20
> On Thu, Jan 18, 2018 at 09:38:39AM +0100, Thomas Monjalon wrote:
> > 18/01/2018 04:14, Yuanhan Liu:
> > > Due to a mistake operation from me, older version (v10) was merged to
> > > master branch. It's the v11 should be applied. However, the master br=
anch
> > > is not rebase-able. Thus, this patch is made, from the diff between v=
10
> > > and v11.
> >
> > Understood it is a mistake.
> > However, you can briefly describes what does this change.
> > Is there a changelog in v11 patch?
>=20
> Yes, ther is:
>=20
> v11:
> - Add check for parameter and tailroom in rte_net_make_rarp_packet.
> - Allocate mbuf in rte_net_make_rarp_packet.
>=20
> > >
> > > Code is from Xiao Wang.
> >
> > You may add his Signed-off.
>=20
> I have no objection. Xiao, okay to you? I will also set the author
> to you.
>=20
> 	--yliu
>=20
> > > Signed-off-by: Yuanhan Liu <yliu@fridaylinux.org>

OK for me.

BRs,
Xiao