From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6842FC433B4 for ; Thu, 13 May 2021 15:11:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42B4A613C8 for ; Thu, 13 May 2021 15:11:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234389AbhEMPNE convert rfc822-to-8bit (ORCPT ); Thu, 13 May 2021 11:13:04 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:36066 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230401AbhEMPND (ORCPT ); Thu, 13 May 2021 11:13:03 -0400 Received: from smtpclient.apple (p4fefc9d6.dip0.t-ipconnect.de [79.239.201.214]) by mail.holtmann.org (Postfix) with ESMTPSA id EE2A5CED28; Thu, 13 May 2021 17:19:40 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.80.0.2.43\)) Subject: Re: [PATCH v2] Bluetooth: Remove spurious error message From: Marcel Holtmann In-Reply-To: <20210513122220.313465-1-szymon.janc@codecoup.pl> Date: Thu, 13 May 2021 17:11:48 +0200 Cc: Bluetooth Kernel Mailing List , stable@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: References: <20210513122220.313465-1-szymon.janc@codecoup.pl> To: Szymon Janc X-Mailer: Apple Mail (2.3654.80.0.2.43) Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Szymon, > Even with rate limited reporting this is very spammy and since > it is remote device that is providing bogus data there is no > need to report this as error. > > Since real_len variable was used only to allow conditional error > message it is now also removed. > > [72454.143336] bt_err_ratelimited: 10 callbacks suppressed > [72454.143337] Bluetooth: hci0: advertising data len corrected > [72454.296314] Bluetooth: hci0: advertising data len corrected > [72454.892329] Bluetooth: hci0: advertising data len corrected > [72455.051319] Bluetooth: hci0: advertising data len corrected > [72455.357326] Bluetooth: hci0: advertising data len corrected > [72455.663295] Bluetooth: hci0: advertising data len corrected > [72455.787278] Bluetooth: hci0: advertising data len corrected > [72455.942278] Bluetooth: hci0: advertising data len corrected > [72456.094276] Bluetooth: hci0: advertising data len corrected > [72456.249137] Bluetooth: hci0: advertising data len corrected > [72459.416333] bt_err_ratelimited: 13 callbacks suppressed > [72459.416334] Bluetooth: hci0: advertising data len corrected > [72459.721334] Bluetooth: hci0: advertising data len corrected > [72460.011317] Bluetooth: hci0: advertising data len corrected > [72460.327171] Bluetooth: hci0: advertising data len corrected > [72460.638294] Bluetooth: hci0: advertising data len corrected > [72460.946350] Bluetooth: hci0: advertising data len corrected > [72461.225320] Bluetooth: hci0: advertising data len corrected > [72461.690322] Bluetooth: hci0: advertising data len corrected > [72462.118318] Bluetooth: hci0: advertising data len corrected > [72462.427319] Bluetooth: hci0: advertising data len corrected > [72464.546319] bt_err_ratelimited: 7 callbacks suppressed > [72464.546319] Bluetooth: hci0: advertising data len corrected > [72464.857318] Bluetooth: hci0: advertising data len corrected > [72465.163332] Bluetooth: hci0: advertising data len corrected > [72465.278331] Bluetooth: hci0: advertising data len corrected > [72465.432323] Bluetooth: hci0: advertising data len corrected > [72465.891334] Bluetooth: hci0: advertising data len corrected > [72466.045334] Bluetooth: hci0: advertising data len corrected > [72466.197321] Bluetooth: hci0: advertising data len corrected > [72466.340318] Bluetooth: hci0: advertising data len corrected > [72466.498335] Bluetooth: hci0: advertising data len corrected > [72469.803299] bt_err_ratelimited: 10 callbacks suppressed > > Signed-off-by: Szymon Janc > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=203753 > Cc: stable@vger.kernel.org > --- > net/bluetooth/hci_event.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c > index 5e99968939ce..26846d338fa7 100644 > --- a/net/bluetooth/hci_event.c > +++ b/net/bluetooth/hci_event.c > @@ -5441,7 +5441,7 @@ static void process_adv_report(struct hci_dev *hdev, u8 type, bdaddr_t *bdaddr, > struct hci_conn *conn; > bool match; > u32 flags; > - u8 *ptr, real_len; > + u8 *ptr; > > switch (type) { > case LE_ADV_IND: > @@ -5472,14 +5472,8 @@ static void process_adv_report(struct hci_dev *hdev, u8 type, bdaddr_t *bdaddr, > break; > } > > - real_len = ptr - data; > - > /* Adjust for actual length */ > - if (len != real_len) { > - bt_dev_err_ratelimited(hdev, "advertising data len corrected %u -> %u", > - len, real_len); > - len = real_len; > - } > + len = ptr - data; please put a comment above the statement that this handles the case of incorrect advertising data len. Regards Marcel