From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from senator.holtmann.net ([87.106.208.187]:37441 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750742AbbA3SFa convert rfc822-to-8bit (ORCPT ); Fri, 30 Jan 2015 13:05:30 -0500 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) Subject: Re: [PATCH V2 5/6] rtlwifi: btcoexist: Add routines for RTL8812AE kernel socket communications From: Marcel Holtmann In-Reply-To: <54CBA0CE.8030800@lwfinger.net> Date: Fri, 30 Jan 2015 10:05:24 -0800 Cc: Kalle Valo , linux-wireless , Troy Tan , netdev@vger.kernel.org, linux-bluetooth@vger.kernel.org Message-Id: (sfid-20150130_190538_034930_6BAC627D) References: <1422304934-9239-1-git-send-email-Larry.Finger@lwfinger.net> <1422304934-9239-6-git-send-email-Larry.Finger@lwfinger.net> <87h9v8zkuh.fsf@kamboji.qca.qualcomm.com> <54CBA0CE.8030800@lwfinger.net> To: Larry Finger Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Larry, >>> I'm adding bluetooth list to the discussion. Full patch is available >>> here: >>> >>> https://patchwork.kernel.org/patch/5712591/ >>> So the wireless driver communicates with the bluetooth driver (which is >>> not in upstream) via a localhost UDP connection? >> >> I think the first order of business should be to get the Bluetooth driver upstream. Until that has happened this is all kinda pointless discussion. > > I agree with this; however, the last time I tried to submit a BT driver for Realtek, I was told that this driver should use some (as yet included) feature. I have watched the driver development, and if that feature was ever included, it was in a form that I did not recognize. I'm sorry that this is vague, but this happened a long time ago. if the Bluetooth side is running over USB, then it should be driven from the existing btusb.ko module with a vendor specific ->setup() callback. However nothing materialized that I could merge it. >>> I know there's a general need for something similar like this, but it >>> needs to properly discussed and designed. >> >> This is just insane. Clear NAK. >> >> Two kernel modules will not use UDP ports over the loopback interface to communicate with each other. > > I will work on combining the latest BT drivers from Realtek with btusb to see if I can achieve a patch that will both work with the Realtek hardware, and get approval from the reviewers. > > What would be an approved method of communicating between two kernel modules? Is there some example in the kernel that I could study? We need a btcoex subsystem that both WiFi and Bluetooth can register to and communicate with. Regards Marcel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcel Holtmann Subject: Re: [PATCH V2 5/6] rtlwifi: btcoexist: Add routines for RTL8812AE kernel socket communications Date: Fri, 30 Jan 2015 10:05:24 -0800 Message-ID: References: <1422304934-9239-1-git-send-email-Larry.Finger@lwfinger.net> <1422304934-9239-6-git-send-email-Larry.Finger@lwfinger.net> <87h9v8zkuh.fsf@kamboji.qca.qualcomm.com> <54CBA0CE.8030800@lwfinger.net> Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\)) Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT Cc: Kalle Valo , linux-wireless , Troy Tan , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Larry Finger Return-path: In-Reply-To: <54CBA0CE.8030800-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org> Sender: linux-bluetooth-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Hi Larry, >>> I'm adding bluetooth list to the discussion. Full patch is available >>> here: >>> >>> https://patchwork.kernel.org/patch/5712591/ >>> So the wireless driver communicates with the bluetooth driver (which is >>> not in upstream) via a localhost UDP connection? >> >> I think the first order of business should be to get the Bluetooth driver upstream. Until that has happened this is all kinda pointless discussion. > > I agree with this; however, the last time I tried to submit a BT driver for Realtek, I was told that this driver should use some (as yet included) feature. I have watched the driver development, and if that feature was ever included, it was in a form that I did not recognize. I'm sorry that this is vague, but this happened a long time ago. if the Bluetooth side is running over USB, then it should be driven from the existing btusb.ko module with a vendor specific ->setup() callback. However nothing materialized that I could merge it. >>> I know there's a general need for something similar like this, but it >>> needs to properly discussed and designed. >> >> This is just insane. Clear NAK. >> >> Two kernel modules will not use UDP ports over the loopback interface to communicate with each other. > > I will work on combining the latest BT drivers from Realtek with btusb to see if I can achieve a patch that will both work with the Realtek hardware, and get approval from the reviewers. > > What would be an approved method of communicating between two kernel modules? Is there some example in the kernel that I could study? We need a btcoex subsystem that both WiFi and Bluetooth can register to and communicate with. Regards Marcel