From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43940)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ilg@livius.net>) id 1amTpo-0004YA-E5
	for qemu-devel@nongnu.org; Sat, 02 Apr 2016 18:16:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ilg@livius.net>) id 1amTpl-0006r3-5Q
	for qemu-devel@nongnu.org; Sat, 02 Apr 2016 18:16:00 -0400
Received: from mail-lb0-x22f.google.com ([2a00:1450:4010:c04::22f]:32941)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ilg@livius.net>) id 1amTpk-0006qx-TG
	for qemu-devel@nongnu.org; Sat, 02 Apr 2016 18:15:57 -0400
Received: by mail-lb0-x22f.google.com with SMTP id u8so108581809lbk.0
	for <qemu-devel@nongnu.org>; Sat, 02 Apr 2016 15:15:56 -0700 (PDT)
Received: from [172.16.62.12] ([109.99.239.84])
	by smtp.gmail.com with ESMTPSA id
	xx3sm20578804wjc.32.2016.04.02.15.15.54 for <qemu-devel@nongnu.org>
	(version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
	Sat, 02 Apr 2016 15:15:54 -0700 (PDT)
From: Liviu Ionescu <ilg@livius.net>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Message-Id: <B870215E-CF53-41BD-A4C3-E944B00495E9@livius.net>
Date: Sun, 3 Apr 2016 01:15:53 +0300
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Subject: [Qemu-devel] segmentation fault in
	object.c:type_initialize_interface() if interface not defined
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

I just updated GNU ARM Eclipse QEMU to 2.5.1 and initially I had some =
problems, main() failed quite early, in the first call to =
`find_default_machine()`.

After several debug sessions, I identified the problem to be a null =
pointer when a referred interface is not defined. In my Cortex-M =
specific configuration, `arm/boot.c` was not included in the build, but =
TYPE_ARM_LINUX_BOOT_IF was referred by TYPE_ARM_GIC_COMMON, the parent =
of my NVIC object.

I guess the problem is in `object.c:type_initialize()`, which does not =
check the pointer returned by:

`TypeImpl *t =3D type_get_by_name(ti->interfaces[i].typename)`=20

and calls=20

`type_initialize_interface(ti, t, t);`=20

with the null pointers.


Normally an assert would be enough, but I don't know exactly which of =
your asserts better fit here, so I would abstain from submitting a =
patch.


Regards,

Liviu