From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762336AbdJQNfm convert rfc822-to-8bit (ORCPT ); Tue, 17 Oct 2017 09:35:42 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:14320 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762322AbdJQNfj (ORCPT ); Tue, 17 Oct 2017 09:35:39 -0400 From: "Liuwenliang (Lamb)" To: Russell King - ARM Linux , Florian Fainelli CC: "aryabinin@virtuozzo.com" , "afzal.mohd.ma@gmail.com" , "labbott@redhat.com" , "kirill.shutemov@linux.intel.com" , "mhocko@suse.com" , "cdall@linaro.org" , "marc.zyngier@arm.com" , "catalin.marinas@arm.com" , "akpm@linux-foundation.org" , "mawilcox@microsoft.com" , "tglx@linutronix.de" , "thgarnie@google.com" , "keescook@chromium.org" , "arnd@arndb.de" , "vladimir.murzin@arm.com" , "tixy@linaro.org" , "ard.biesheuvel@linaro.org" , "robin.murphy@arm.com" , "mingo@kernel.org" , "grygorii.strashko@linaro.org" , "opendmb@gmail.com" , "linux-kernel@vger.kernel.org" , "kasan-dev@googlegroups.com" , Zengweilin , "linux-mm@kvack.org" , Dailei , "glider@google.com" , "dvyukov@google.com" , Jiazhenghua , "linux-arm-kernel@lists.infradead.org" , Heshaoliang Subject: Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory Thread-Topic: [PATCH 01/11] Initialize the mapping of KASan shadow memory Thread-Index: AQHTQmokZ5ece1W6v0+GfMCIss4ZwaLehmmAgAAiDYCACWPbwA== Date: Tue, 17 Oct 2017 13:28:25 +0000 Message-ID: References: <20171011082227.20546-1-liuwenliang@huawei.com> <20171011082227.20546-2-liuwenliang@huawei.com> <20171011214131.GV20805@n2100.armlinux.org.uk> In-Reply-To: <20171011214131.GV20805@n2100.armlinux.org.uk> Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.57.90.243] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.59E60585.0106,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=169.254.12.139, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 902178c3f21c86561dbedc3fb2c69c2e Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2017.10.12 05:42 AM Russell King - ARM Linux [mailto:linux@armlinux.org.uk] wrote: >> Please don't make this "exclusive" just conditionally call >> kasan_early_init(), remove the call to start_kernel from >> kasan_early_init and keep the call to start_kernel here. >iow: > >#ifdef CONFIG_KASAN > bl kasan_early_init >#endif > b start_kernel > >This has the advantage that we don't leave any stack frame from >kasan_early_init() on the init task stack. Thanks for your review. I tested your opinion and it work well. I agree with you that it is better to use follow code #ifdef CONFIG_KASAN bl kasan_early_init #endif b start_kernel than : #ifdef CONFIG_KASAN bl kasan_early_init #else b start_kernel #endif From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f72.google.com (mail-lf0-f72.google.com [209.85.215.72]) by kanga.kvack.org (Postfix) with ESMTP id DC1A66B0038 for ; Tue, 17 Oct 2017 09:42:12 -0400 (EDT) Received: by mail-lf0-f72.google.com with SMTP id k40so454896lfi.5 for ; Tue, 17 Oct 2017 06:42:12 -0700 (PDT) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com. [45.249.212.188]) by mx.google.com with ESMTPS id j19si3099866lfg.676.2017.10.17.06.42.09 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 17 Oct 2017 06:42:11 -0700 (PDT) From: "Liuwenliang (Lamb)" Subject: Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory Date: Tue, 17 Oct 2017 13:28:25 +0000 Message-ID: References: <20171011082227.20546-1-liuwenliang@huawei.com> <20171011082227.20546-2-liuwenliang@huawei.com> <20171011214131.GV20805@n2100.armlinux.org.uk> In-Reply-To: <20171011214131.GV20805@n2100.armlinux.org.uk> Content-Language: zh-CN Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: owner-linux-mm@kvack.org List-ID: To: Russell King - ARM Linux , Florian Fainelli Cc: "aryabinin@virtuozzo.com" , "afzal.mohd.ma@gmail.com" , "labbott@redhat.com" , "kirill.shutemov@linux.intel.com" , "mhocko@suse.com" , "cdall@linaro.org" , "marc.zyngier@arm.com" , "catalin.marinas@arm.com" , "akpm@linux-foundation.org" , "mawilcox@microsoft.com" , "tglx@linutronix.de" , "thgarnie@google.com" , "keescook@chromium.org" , "arnd@arndb.de" , "vladimir.murzin@arm.com" , "tixy@linaro.org" , "ard.biesheuvel@linaro.org" , "robin.murphy@arm.com" , "mingo@kernel.org" , "grygorii.strashko@linaro.org" , "opendmb@gmail.com" , "linux-kernel@vger.kernel.org" , "kasan-dev@googlegroups.com" , Zengweilin , "linux-mm@kvack.org" , Dailei , "glider@google.com" , "dvyukov@google.com" , Jiazhenghua , "linux-arm-kernel@lists.infradead.org" , Heshaoliang 2017.10.12 05:42 AM Russell King - ARM Linux [mailto:linux@armlinux.org.u= k] wrote: >> Please don't make this "exclusive" just conditionally call=20 >> kasan_early_init(), remove the call to start_kernel from=20 >> kasan_early_init and keep the call to start_kernel here. >iow: > >#ifdef CONFIG_KASAN > bl kasan_early_init >#endif > b start_kernel > >This has the advantage that we don't leave any stack frame from >kasan_early_init() on the init task stack. Thanks for your review. I tested your opinion and it work well. I agree with you that it is better to use follow code #ifdef CONFIG_KASAN bl kasan_early_init #endif b start_kernel than : #ifdef CONFIG_KASAN bl kasan_early_init #else b start_kernel #endif -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: liuwenliang@huawei.com (Liuwenliang (Lamb)) Date: Tue, 17 Oct 2017 13:28:25 +0000 Subject: [PATCH 01/11] Initialize the mapping of KASan shadow memory In-Reply-To: <20171011214131.GV20805@n2100.armlinux.org.uk> References: <20171011082227.20546-1-liuwenliang@huawei.com> <20171011082227.20546-2-liuwenliang@huawei.com> <20171011214131.GV20805@n2100.armlinux.org.uk> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 2017.10.12 05:42 AM Russell King - ARM Linux [mailto:linux at armlinux.org.uk] wrote: >> Please don't make this "exclusive" just conditionally call >> kasan_early_init(), remove the call to start_kernel from >> kasan_early_init and keep the call to start_kernel here. >iow: > >#ifdef CONFIG_KASAN > bl kasan_early_init >#endif > b start_kernel > >This has the advantage that we don't leave any stack frame from >kasan_early_init() on the init task stack. Thanks for your review. I tested your opinion and it work well. I agree with you that it is better to use follow code #ifdef CONFIG_KASAN bl kasan_early_init #endif b start_kernel than : #ifdef CONFIG_KASAN bl kasan_early_init #else b start_kernel #endif