From: Frediano Ziglio <frediano.ziglio@huawei.com>
To: Julien Grall <julien.grall@linaro.org>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@citrix.com>,
Tim Deegan <tim@xen.org>
Cc: Zoltan Kiss <zoltan.kiss@huawei.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2 2/7] xen/arm: Implement hip04-d01 platform
Date: Tue, 4 Nov 2014 14:17:08 +0000 [thread overview]
Message-ID: <B944B469BF5302468AC6EB05E56CC70D17B168@lhreml509-mbb> (raw)
In-Reply-To: <5458DCC9.9090406@linaro.org>
> On 11/04/2014 01:52 PM, Frediano Ziglio wrote:
> >>
> >> [..]
> >>
> >>> +static void __init hip04_iounmap(void __iomem **p) {
> >>> + if ( *p )
> >>> + {
> >>> + iounmap(*p);
> >>> + *p = NULL;
> >>> + }
> >>> +}
> >>
> >> What is used for? Should not iounmap enough?
> >>
> >
> > I just like to clear pointers after freeing them.
>
> It's not really useful :).
>
Just paranoia :)
Never liked dandling pointers.
> If you really want to keep the *p = NULL. This could be simplify into:
>
> hip04_iounmap(....)
> {
> iounmap(*p);
> *p = NULL;
> }
>
> This is because iounmap takes care of NULL pointer.
>
Are you sure? I looked at code and is not a simple vm_free call, it does some mapping even if address is NULL.
Regards,
Frediano
next prev parent reply other threads:[~2014-11-04 14:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 16:46 xen/arm: Add support for Huawei hip04-d01 platform Frediano Ziglio
2014-11-03 16:46 ` [PATCH v2 1/7] xen/device_tree: Add new helper to read arrays from a DTB Frediano Ziglio
2014-11-04 13:14 ` Julien Grall
2014-11-04 13:55 ` Frediano Ziglio
2014-11-04 14:00 ` Julien Grall
2014-11-03 16:46 ` [PATCH v2 2/7] xen/arm: Implement hip04-d01 platform Frediano Ziglio
2014-11-04 13:21 ` Julien Grall
2014-11-04 13:52 ` Frediano Ziglio
2014-11-04 14:03 ` Julien Grall
2014-11-04 14:17 ` Frediano Ziglio [this message]
2014-11-04 14:23 ` Julien Grall
2014-11-03 16:46 ` [PATCH v2 3/7] xen/arm: Make gic-v2 code handle " Frediano Ziglio
2014-11-04 13:31 ` Julien Grall
2014-11-04 13:34 ` Julien Grall
2014-11-04 15:54 ` Frediano Ziglio
2014-11-04 13:35 ` Julien Grall
2014-11-03 16:46 ` [PATCH v2 4/7] xen/arm: Add support for DTBs with strange names of Hip04 GICv2 Frediano Ziglio
2014-11-03 16:46 ` [PATCH v2 5/7] xen/arm: handle GICH register changes for hip04-d01 platform Frediano Ziglio
2014-11-03 16:46 ` [PATCH v2 6/7] xen/arm: Force domains to use normal GICv2 driver on Hip04 platform Frediano Ziglio
2014-11-04 13:33 ` Julien Grall
2014-11-04 14:10 ` Frediano Ziglio
2014-11-03 16:46 ` [PATCH v2 7/7] xen/arm: Move vGIC registers " Frediano Ziglio
2014-11-04 13:38 ` Julien Grall
2014-11-04 14:42 ` Frediano Ziglio
2014-11-04 14:50 ` Ian Campbell
2014-11-04 15:48 ` Frediano Ziglio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B944B469BF5302468AC6EB05E56CC70D17B168@lhreml509-mbb \
--to=frediano.ziglio@huawei.com \
--cc=ian.campbell@citrix.com \
--cc=julien.grall@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
--cc=zoltan.kiss@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.