From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751471AbaKGKDG (ORCPT ); Fri, 7 Nov 2014 05:03:06 -0500 Received: from lhrrgout.huawei.com ([194.213.3.17]:47993 "EHLO lhrrgout.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750974AbaKGKDD (ORCPT ); Fri, 7 Nov 2014 05:03:03 -0500 X-Greylist: delayed 365 seconds by postgrey-1.27 at vger.kernel.org; Fri, 07 Nov 2014 05:03:02 EST From: Frediano Ziglio To: Stefano Stabellini , Frediano Ziglio CC: "xen-devel@lists.xenproject.org" , "Boris Ostrovsky" , David Vrabel , "linux-kernel@vger.kernel.org" Subject: RE: [Xen-devel] [PATCH] xen/arm: Return correct code error for xen_swiotlb_map_page Thread-Topic: [Xen-devel] [PATCH] xen/arm: Return correct code error for xen_swiotlb_map_page Thread-Index: AQHP+eQybFi0WqSOD0+2fx6E4sVCLJxT2xKAgAAaXQCAAAKpgIAA9P6w Date: Fri, 7 Nov 2014 09:56:36 +0000 Message-ID: References: <1415293651-13917-1-git-send-email-frediano.ziglio@huawei.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.47.66.6] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id sA7A3C3W012120 > On Thu, 6 Nov 2014, Frediano Ziglio wrote: > > 2014-11-06 17:30 GMT+00:00 Stefano Stabellini > : > > On Thu, 6 Nov 2014, Frediano Ziglio wrote: > > > On ARM error code is not 0 so avoid to return it as error. > > > > > > Signed-off-by: Frediano Ziglio > > > > Acked-by: Stefano Stabellini > > > > > > Could you please fix the same error in lib/swiotlb.c too please? > > > > > > Same patch or another ? > > > > Another > lib/swiotlb.c is not affected at a physical address to io_tlb_overflow_buffer is returned in case of error. Looks like a way to transform silently an allocation error to a more serious memory corruption. Frediano > > > > >  drivers/xen/swiotlb-xen.c | 2 +- > > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb- > xen.c > > > index ebd8f21..3b8d628 100644 > > > --- a/drivers/xen/swiotlb-xen.c > > > +++ b/drivers/xen/swiotlb-xen.c > > > @@ -425,7 +425,7 @@ dma_addr_t xen_swiotlb_map_page(struct > device *dev, struct page *page, > > >        */ > > >       if (!dma_capable(dev, dev_addr, size)) { > > >               swiotlb_tbl_unmap_single(dev, map, size, dir); > > > -             dev_addr = 0; > > > +             dev_addr = DMA_ERROR_CODE; > > >       } > > >       return dev_addr; > > >  } > > > -- > > > 1.9.1 > > > > > > > > > -- > > > To unsubscribe from this list: send the line "unsubscribe > linux-kernel" in > > > the body of a message to majordomo@vger.kernel.org > > > More majordomo info at  http://vger.kernel.org/majordomo- > info.html > > > Please read the FAQ at http://secure- > web.cisco.com/1cvjROyUxV6SnA0uBTMRubqrQWsaXGhps- > FWjY3vly9AxaKKlt2DPY7GjL0FCHeP4rsbjKsc-P4zH2_7-kpcxwEH-udGrGCCq > > kCLlH1-fLOo1X6Nlui6EwEVHUpB2r7gt- > Gsgxbep9QWPnIdypDPNf8Hf5clxCMXYcvWsOK5s3qg/http%3A%2F%2Fwww.tux.org%2Fl > kml%2F > > > > > > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xen.org > > http://lists.xen.org/xen-devel > > > > > > > > {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frediano Ziglio Subject: Re: [PATCH] xen/arm: Return correct code error for xen_swiotlb_map_page Date: Fri, 7 Nov 2014 09:56:36 +0000 Message-ID: References: <1415293651-13917-1-git-send-email-frediano.ziglio@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XmgHg-0005vb-Ou for xen-devel@lists.xenproject.org; Fri, 07 Nov 2014 09:56:48 +0000 In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini , Frediano Ziglio Cc: "xen-devel@lists.xenproject.org" , Boris Ostrovsky , David Vrabel , "linux-kernel@vger.kernel.org" List-Id: xen-devel@lists.xenproject.org PiBPbiBUaHUsIDYgTm92IDIwMTQsIEZyZWRpYW5vIFppZ2xpbyB3cm90ZToNCj4gPiAyMDE0LTEx LTA2IDE3OjMwIEdNVCswMDowMCBTdGVmYW5vIFN0YWJlbGxpbmkNCj4gPHN0ZWZhbm8uc3RhYmVs bGluaUBldS5jaXRyaXguY29tPjoNCj4gPiAgICAgICBPbiBUaHUsIDYgTm92IDIwMTQsIEZyZWRp YW5vIFppZ2xpbyB3cm90ZToNCj4gPiAgICAgICA+IE9uIEFSTSBlcnJvciBjb2RlIGlzIG5vdCAw IHNvIGF2b2lkIHRvIHJldHVybiBpdCBhcyBlcnJvci4NCj4gPiAgICAgICA+DQo+ID4gICAgICAg PiBTaWduZWQtb2ZmLWJ5OiBGcmVkaWFubyBaaWdsaW8gPGZyZWRpYW5vLnppZ2xpb0BodWF3ZWku Y29tPg0KPiA+DQo+ID4gICAgICAgQWNrZWQtYnk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3RlZmFu by5zdGFiZWxsaW5pQGV1LmNpdHJpeC5jb20+DQo+ID4NCj4gPg0KPiA+ICAgICAgIENvdWxkIHlv dSBwbGVhc2UgZml4IHRoZSBzYW1lIGVycm9yIGluIGxpYi9zd2lvdGxiLmMgdG9vIHBsZWFzZT8N Cj4gPg0KPiA+DQo+ID4gU2FtZSBwYXRjaCBvciBhbm90aGVyID8NCj4gPg0KPiANCj4gQW5vdGhl cg0KPiANCg0KbGliL3N3aW90bGIuYyBpcyBub3QgYWZmZWN0ZWQgYXQgYSBwaHlzaWNhbCBhZGRy ZXNzIHRvIGlvX3RsYl9vdmVyZmxvd19idWZmZXIgaXMgcmV0dXJuZWQgaW4gY2FzZSBvZiBlcnJv ci4NCkxvb2tzIGxpa2UgYSB3YXkgdG8gdHJhbnNmb3JtIHNpbGVudGx5IGFuIGFsbG9jYXRpb24g ZXJyb3IgdG8gYSBtb3JlIHNlcmlvdXMgbWVtb3J5IGNvcnJ1cHRpb24uDQoNCkZyZWRpYW5vDQoN Cj4gPg0KPiA+ICAgICAgID7CoCBkcml2ZXJzL3hlbi9zd2lvdGxiLXhlbi5jIHwgMiArLQ0KPiA+ ICAgICAgID7CoCAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkN Cj4gPiAgICAgICA+DQo+ID4gICAgICAgPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy94ZW4vc3dpb3Rs Yi14ZW4uYyBiL2RyaXZlcnMveGVuL3N3aW90bGItDQo+IHhlbi5jDQo+ID4gICAgICAgPiBpbmRl eCBlYmQ4ZjIxLi4zYjhkNjI4IDEwMDY0NA0KPiA+ICAgICAgID4gLS0tIGEvZHJpdmVycy94ZW4v c3dpb3RsYi14ZW4uYw0KPiA+ICAgICAgID4gKysrIGIvZHJpdmVycy94ZW4vc3dpb3RsYi14ZW4u Yw0KPiA+ICAgICAgID4gQEAgLTQyNSw3ICs0MjUsNyBAQCBkbWFfYWRkcl90IHhlbl9zd2lvdGxi X21hcF9wYWdlKHN0cnVjdA0KPiBkZXZpY2UgKmRldiwgc3RydWN0IHBhZ2UgKnBhZ2UsDQo+ID4g ICAgICAgPsKgIMKgIMKgIMKgICovDQo+ID4gICAgICAgPsKgIMKgIMKgIMKgaWYgKCFkbWFfY2Fw YWJsZShkZXYsIGRldl9hZGRyLCBzaXplKSkgew0KPiA+ICAgICAgID7CoCDCoCDCoCDCoCDCoCDC oCDCoCDCoHN3aW90bGJfdGJsX3VubWFwX3NpbmdsZShkZXYsIG1hcCwgc2l6ZSwgZGlyKTsNCj4g PiAgICAgICA+IC3CoCDCoCDCoCDCoCDCoCDCoCDCoGRldl9hZGRyID0gMDsNCj4gPiAgICAgICA+ ICvCoCDCoCDCoCDCoCDCoCDCoCDCoGRldl9hZGRyID0gRE1BX0VSUk9SX0NPREU7DQo+ID4gICAg ICAgPsKgIMKgIMKgIMKgfQ0KPiA+ICAgICAgID7CoCDCoCDCoCDCoHJldHVybiBkZXZfYWRkcjsN Cj4gPiAgICAgICA+wqAgfQ0KPiA+ICAgICAgID4gLS0NCj4gPiAgICAgICA+IDEuOS4xDQo+ID4g ICAgICAgPg0KPiA+ICAgICAgID4NCj4gPiAgICAgICA+IC0tDQo+ID4gICAgICAgPiBUbyB1bnN1 YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUNCj4gbGlu dXgta2VybmVsIiBpbg0KPiA+ICAgICAgID4gdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9y ZG9tb0B2Z2VyLmtlcm5lbC5vcmcNCj4gPiAgICAgICA+IE1vcmUgbWFqb3Jkb21vIGluZm8gYXTC oCBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby0NCj4gaW5mby5odG1sDQo+ID4gICAg ICAgPiBQbGVhc2UgcmVhZCB0aGUgRkFRIGF0wqBodHRwOi8vc2VjdXJlLQ0KPiB3ZWIuY2lzY28u Y29tLzFjdmpST3lVeFY2U25BMHVCVE1SdWJxclFXc2FYR2hwcy0NCj4gRldqWTN2bHk5QXhhS0ts dDJEUFk3R2pMMEZDSGVQNHJzYmpLc2MtUDR6SDJfNy1rcGN4d0VILXVkR3JHQ0NxDQo+ID4gICAg ICAga0NMbEgxLWZMT28xWDZObHVpNkV3RVZIVXBCMnI3Z3QtDQo+IEdzZ3hiZXA5UVdQbklkeXBE UE5mOEhmNWNseENNWFljdldzT0s1czNxZy9odHRwJTNBJTJGJTJGd3d3LnR1eC5vcmclMkZsDQo+ IGttbCUyRg0KPiA+ICAgICAgID4NCj4gPg0KPiA+ICAgICAgIF9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fDQo+ID4gICAgICAgWGVuLWRldmVsIG1haWxpbmcg bGlzdA0KPiA+ICAgICAgIFhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnDQo+ID4gICAgICAgaHR0cDov L2xpc3RzLnhlbi5vcmcveGVuLWRldmVsDQo+ID4NCj4gPg0KPiA+DQo+ID4NCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxp c3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cDovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVs Cg==