From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, HK_RANDOM_FROM,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 425D1C4321A for ; Fri, 28 Jun 2019 01:36:37 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id C9E202086D for ; Fri, 28 Jun 2019 01:36:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9E202086D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D5EF4F64; Fri, 28 Jun 2019 03:36:35 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B9ACBF04 for ; Fri, 28 Jun 2019 03:36:34 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2019 18:36:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,425,1557212400"; d="scan'208";a="185478585" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga004.fm.intel.com with ESMTP; 27 Jun 2019 18:36:32 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 27 Jun 2019 18:36:32 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 27 Jun 2019 18:36:32 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.87]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.72]) with mapi id 14.03.0439.000; Fri, 28 Jun 2019 09:36:30 +0800 From: "Li, Xiaoyun" To: "Wu, Jingjing" , "Wiles, Keith" , "Liang, Cunming" , "Maslekar, Omkar" CC: "dev@dpdk.org" Thread-Topic: [PATCH v8 4/6] examples/ntb: enable an example for ntb Thread-Index: AQHVK+6qhasYgrreH0GoCO0efkXrGqavPgSAgAENNwA= Date: Fri, 28 Jun 2019 01:36:30 +0000 Message-ID: References: <20190620102147.41557-1-xiaoyun.li@intel.com> <20190626071224.4819-1-xiaoyun.li@intel.com> <20190626071224.4819-5-xiaoyun.li@intel.com> <9BB6961774997848B5B42BEC655768F81146A455@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F81146A455@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v8 4/6] examples/ntb: enable an example for ntb X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi > -----Original Message----- > From: Wu, Jingjing > Sent: Friday, June 28, 2019 01:30 > To: Li, Xiaoyun ; Wiles, Keith ; > Liang, Cunming ; Maslekar, Omkar > > Cc: dev@dpdk.org > Subject: RE: [PATCH v8 4/6] examples/ntb: enable an example for ntb >=20 > > -----Original Message----- > > From: Li, Xiaoyun > > Sent: Wednesday, June 26, 2019 3:12 PM > > To: Wu, Jingjing ; Wiles, Keith > > ; Liang, Cunming ; > > Maslekar, Omkar > > Cc: dev@dpdk.org; Li, Xiaoyun > > Subject: [PATCH v8 4/6] examples/ntb: enable an example for ntb > > > > Enable an example for rawdev ntb. Support interactive mode to send > > file on one host and receive file from another host. The command line > > would be 'send [filepath]' and 'receive [filepath]'. > > > > But since the FIFO is not enabled right now, use rte_memcpy as the > > enqueue and dequeue functions and only support transmitting file no mor= e > than 4M. > > > > Signed-off-by: Xiaoyun Li > Reviewed-by: Jingjing Wu >=20 > The test app looks fine currently. > Just one thought, if this example is temporary, can we just move this pat= ch to > test instead of example. As when the FIFO is done, this one be modified, = right? The file transmission will be reserved in next release, just support any si= ze in next because of the introduce of FIFO. And will add new cmdline to iofwd ntb device and eth device in next release= . So example is a more appropriate choice. >=20 > Thanks > Jingjing