From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Li, Xiaoyun" Subject: Re: [PATCH v2] app/testpmd: fix little perf drop with XL710 Date: Thu, 12 Jul 2018 08:01:36 +0000 Message-ID: References: <1531189709-312497-1-git-send-email-xiaoyun.li@intel.com> <1531275335-29234-1-git-send-email-xiaoyun.li@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B803A5C@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "stable@dpdk.org" To: "Lu, Wenzhuo" , "Zhang, Qi Z" Return-path: In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B803A5C@shsmsx102.ccr.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" OK. I will modify the commit log and name and send v3 later. Thanks. > -----Original Message----- > From: Lu, Wenzhuo > Sent: Thursday, July 12, 2018 13:56 > To: Li, Xiaoyun ; Zhang, Qi Z > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH v2] app/testpmd: fix little perf drop with XL710 >=20 > Hi Xiaoyun, >=20 >=20 > > -----Original Message----- > > From: Li, Xiaoyun > > Sent: Wednesday, July 11, 2018 10:16 AM > > To: Zhang, Qi Z ; Lu, Wenzhuo > > > > Cc: dev@dpdk.org; Li, Xiaoyun ; stable@dpdk.org > > Subject: [PATCH v2] app/testpmd: fix little perf drop with XL710 > > > > There is about 1.8M perf drop with XL710. And it is because of a > > bitrate > What's 1.8M mean? BPS? PPS? > Looks like this patch fixes the CPU consuming problem and has nothing to = do > with a specific NIC. > 2 suggestions. > Just omit XL710, also in the tittle. > Maybe better mentioning how many percent drop but not an accurate > number. >=20 > Except that, Acked-by: Wenzhuo Lu >=20 >=20 > > calculation in the datapath. So improve it by maintaining an array of > > port indexes in testpmd, which is updated with ethdev events. > > > > Fixes: 8728ccf37615 ("fix ethdev ports enumeration") > > Cc: stable@dpdk.org > > > > Signed-off-by: Xiaoyun Li