Re: [PATCH] i2c: Mark instantiated device nodes with OF_POPULATE

From: Pantelis Antoniou <pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
To: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Kevin Hilman <khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
	Matt Porter <matt.porter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	Grant Likely
	<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
	"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] i2c: Mark instantiated device nodes with OF_POPULATE
Date: Wed, 10 Jun 2015 16:51:27 +0300	[thread overview]
Message-ID: <B9EA0BC3-56D8-4676-BEFC-734EC1FE6649@konsulko.com> (raw)
In-Reply-To: <20150610124949.GC1592@katana>

Hi Wolfram,

> On Jun 10, 2015, at 15:49 , Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> wrote:
> 
> On Wed, Jun 10, 2015 at 07:42:59AM -0500, Rob Herring wrote:
>> On Wed, Jun 10, 2015 at 12:40 AM, Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> wrote:
>>> 
>>>>>>>> Mark (and unmark) device nodes with the POPULATE flag as appropriate.
>>>>>>>> This is required to avoid multi probing when using I2C and device
>>>>>>>> overlays containing a mux.
>>>>>>>> This patch is also more careful with the release of the adapter device
>>>>>>>> which caused a deadlock with muxes, and does not break the build
>>>>>>>> on !OF since the node flag accessors are not defined then.
>>>>>>>> 
>>>>>>>> Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
>>>>>>> 
>>>>>>> Now, that the dependency is upstream: applied to for-current, thanks!
>>>>>> 
>>>>>> I'm not seeing this in linux-next, or in your for-current branch.
>>>>>> 
>>>>>> Was this dropped or superseded by something else?
>>>>> 
>>>>> I dropped it because it caused a build bug. So, we need another
>>>>> dependency in... I am not sure if this is already in.
>>>>> 
>>>> 
>>>> FWIW, I’ve posted the dependency patch already; it’s trivial as you recall.
>>>> 
>>>> Lets hope it gets picked so that this one can go in.
>>> 
>>> Is that in now?
>> 
>> You mean "of: Move OF flags to be visible even when !CONFIG_OF"? If
>> so, it is queued up for 4.2 in my tree.
> 
> Sorry, I lost track of all the fixes needed for this one. I also can't
> recall being CCed to them. Pity.
> 
> IIRC it is the one which adds OF_POPULATED. If so, why is this not
> scheduled for 4.1 as this bugfix depends on it?
> 

No idea. This is an obvious bugfix.

> Pantelis, thanks for all the work yet I must say I am seriously confused
> with the handling of this patch. I thought you wanted the original I2C
> fix applied asap?

I would like to, yes. It’s just the nature of the process when dealing with
multiple kernel trees. I would be happy for someone to pick up and queue it
for 4.1.

Regards

— Pantelis