From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nguyen, Dinh <dinh.nguyen@intel.com>
Date: Fri, 4 May 2018 14:30:12 +0000
Subject: [U-Boot] [PATCH v2 3/3] net: designware: Add reset ctrl to
	driver
In-Reply-To: <1525430961-45527-4-git-send-email-ley.foon.tan@intel.com>
References: <1525430961-45527-1-git-send-email-ley.foon.tan@intel.com>
 <1525430961-45527-4-git-send-email-ley.foon.tan@intel.com>
Message-ID: <BA1B5AF7D118E146A437E44412B8291307BEC6EE@fmsmsx122.amr.corp.intel.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de



> -----Original Message-----
> From: Tan, Ley Foon
> Sent: Friday, May 4, 2018 5:49 AM
> To: u-boot at lists.denx.de
> Cc: Marek Vasut <marex@denx.de>; Ley Foon Tan <lftan.linux@gmail.com>;
> See, Chin Liang <chin.liang.see@intel.com>; Nguyen, Dinh
> <dinh.nguyen@intel.com>; Tan, Ley Foon <ley.foon.tan@intel.com>
> Subject: [PATCH v2 3/3] net: designware: Add reset ctrl to driver
> 
> Add code to reset all reset signals as in Ethernet DT node. A reset property is an
> optional feature, so only print out a warning and do not fail if a reset property is
> not present.
> 
> If a reset property is discovered, then use it to deassert, thus bringing the IP out
> of reset.
> 
> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
> ---
>  drivers/net/designware.c |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/designware.c b/drivers/net/designware.c index
> 765e356..03ef1eb 100644
> --- a/drivers/net/designware.c
> +++ b/drivers/net/designware.c
> @@ -16,6 +16,7 @@
>  #include <miiphy.h>
>  #include <malloc.h>
>  #include <pci.h>
> +#include <reset.h>
>  #include <linux/compiler.h>
>  #include <linux/err.h>
>  #include <linux/kernel.h>
> @@ -711,6 +712,16 @@ int designware_eth_probe(struct udevice *dev)
>  	}
>  #endif
> 
> +#ifdef CONFIG_DM_RESET

You don't need the above wrapper. It's already checked in reset.h

> +	struct reset_ctl_bulk reset_bulk;
> +
> +	ret = reset_get_bulk(dev, &reset_bulk);
> +	if (ret)
> +		dev_warn(dev, "Can't get reset: %d\n", ret);
> +	else
> +		reset_deassert_bulk(&reset_bulk);
> +#endif
> +
>  #ifdef CONFIG_DM_PCI
>  	/*
>  	 * If we are on PCI bus, either directly attached to a PCI root port,
> --
> 1.7.1