From: Anton Altaparmakov <aia21@cam.ac.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-sparse@vger.kernel.org
Subject: Re: Another sparse warning...
Date: Mon, 12 Feb 2007 15:55:46 +0000 [thread overview]
Message-ID: <BA2EBAD3-5474-44C5-B93B-34A40A8A0722@cam.ac.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.0702120742030.8424@woody.linux-foundation.org>
Hi Linus,
On 12 Feb 2007, at 15:50, Linus Torvalds wrote:
> On Mon, 12 Feb 2007, Anton Altaparmakov wrote:
>>
>> What can I do to tell sparse that this code is ok and there should
>> not be a
>> warning? Is there a "__ignore_context_imbalance" or something
>> that I can mark
>> up the {un,}lock_kernel() with or something like that?
>
> No, you should annotate the function as already having the lock when
> entered.
[snip]
> int myfunction(..)
> __releases(kernel_lock)
> __acquires(kernel_lock)
> {
> unlock_kernel();
> ..
> lock_kernel();
> }
Great, thanks! That works a treat. (-:
Best regards,
Anton
--
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer, http://www.linux-ntfs.org/
next prev parent reply other threads:[~2007-02-12 15:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-12 10:23 Another sparse warning Anton Altaparmakov
2007-02-12 15:50 ` Linus Torvalds
2007-02-12 15:55 ` Anton Altaparmakov [this message]
2007-02-13 2:00 ` Christopher Li
2007-02-13 3:48 ` Linus Torvalds
2007-02-13 4:21 ` Christopher Li
2007-02-13 8:49 ` Josh Triplett
2007-02-13 8:38 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BA2EBAD3-5474-44C5-B93B-34A40A8A0722@cam.ac.uk \
--to=aia21@cam.ac.uk \
--cc=linux-sparse@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.