All of lore.kernel.org
 help / color / mirror / Atom feed
From: Muchun Song <muchun.song@linux.dev>
To: Chao Yu <chao@kernel.org>
Cc: Linux MM <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, jaegeuk@kernel.org,
	Chao Yu <chao.yu@oppo.com>,
	stable@kernel.org,
	syzbot+81684812ea68216e08c5@syzkaller.appspotmail.com
Subject: Re: [PATCH] mm/slub: fix to return errno if kmalloc() fails
Date: Wed, 31 Aug 2022 11:09:09 +0800	[thread overview]
Message-ID: <BAC9CE6A-5873-429F-ACE2-E0A9E507D807@linux.dev> (raw)
In-Reply-To: <20220830141009.150075-1-chao@kernel.org>



> On Aug 30, 2022, at 22:10, Chao Yu <chao@kernel.org> wrote:
> 
> From: Chao Yu <chao.yu@oppo.com>
> 
> In create_unique_id(), kmalloc(, GFP_KERNEL) can fail due to
> out-of-memory, if it fails, return errno correctly rather than
> triggering panic via BUG_ON();

I tend to agree with you. A mount operation shouldn’t panic the
kernel.

> 
> kernel BUG at mm/slub.c:5893!
> Internal error: Oops - BUG: 0 [#1] PREEMPT SMP
> 
> Call trace:
> sysfs_slab_add+0x258/0x260 mm/slub.c:5973
> __kmem_cache_create+0x60/0x118 mm/slub.c:4899
> create_cache mm/slab_common.c:229 [inline]
> kmem_cache_create_usercopy+0x19c/0x31c mm/slab_common.c:335
> kmem_cache_create+0x1c/0x28 mm/slab_common.c:390
> f2fs_kmem_cache_create fs/f2fs/f2fs.h:2766 [inline]
> f2fs_init_xattr_caches+0x78/0xb4 fs/f2fs/xattr.c:808
> f2fs_fill_super+0x1050/0x1e0c fs/f2fs/super.c:4149
> mount_bdev+0x1b8/0x210 fs/super.c:1400
> f2fs_mount+0x44/0x58 fs/f2fs/super.c:4512
> legacy_get_tree+0x30/0x74 fs/fs_context.c:610
> vfs_get_tree+0x40/0x140 fs/super.c:1530
> do_new_mount+0x1dc/0x4e4 fs/namespace.c:3040
> path_mount+0x358/0x914 fs/namespace.c:3370
> do_mount fs/namespace.c:3383 [inline]
> __do_sys_mount fs/namespace.c:3591 [inline]
> __se_sys_mount fs/namespace.c:3568 [inline]
> __arm64_sys_mount+0x2f8/0x408 fs/namespace.c:3568
> 
> Cc: <stable@kernel.org>
> Reported-by: syzbot+81684812ea68216e08c5@syzkaller.appspotmail.com
> Signed-off-by: Chao Yu <chao.yu@oppo.com>

Reviewed-by: Muchun Song <songmuchun@bytedance.com>

Thanks.


  reply	other threads:[~2022-08-31  3:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-30 14:10 [PATCH] mm/slub: fix to return errno if kmalloc() fails Chao Yu
2022-08-31  3:09 ` Muchun Song [this message]
2022-09-08 21:25   ` Vlastimil Babka (SUSE)
2022-09-09 20:06     ` Matthew Wilcox
2022-09-09 20:21       ` Vlastimil Babka (SUSE)
2022-09-13  3:27     ` Chao Yu
2022-08-31 13:33 ` Hyeonggon Yoo
2022-09-06 21:33 ` David Rientjes
2022-09-09 16:47 ` Christophe JAILLET
2022-09-13  3:42   ` Chao Yu
2022-09-13  5:26     ` Marion & Christophe JAILLET
2022-09-16 22:58       ` Vlastimil Babka (SUSE)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BAC9CE6A-5873-429F-ACE2-E0A9E507D807@linux.dev \
    --to=muchun.song@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=chao.yu@oppo.com \
    --cc=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=stable@kernel.org \
    --cc=syzbot+81684812ea68216e08c5@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.