From: Hugh Dickins <hughd@google.com>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Matt Fleming <matt@console-pimps.org>,
linux-mm@kvack.org
Subject: Re: [patch v3] oom: replace PF_OOM_ORIGIN with toggling oom_score_adj
Date: Fri, 15 Apr 2011 18:48:09 -0700 [thread overview]
Message-ID: <BANLkTi=BD0PRHPGqmc1KrxwX2cyPdjSc5w@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1104151602270.2738@chino.kir.corp.google.com>
On Fri, Apr 15, 2011 at 4:03 PM, David Rientjes <rientjes@google.com> wrote:
> On Fri, 15 Apr 2011, Hugh Dickins wrote:
>
>> This makes good sense (now you're using MAX instead of MIN!),
>> but may I helatedly ask you to change the name test_set_oom_score_adj()
>> to replace_oom_score_adj()? test_set means a bitflag operation to me.
>>
>
> Does replace_oom_score_adj() imply that it will be returning the old value
> of oom_score_adj like test_set_oom_score_adj() does?
I can easily imagine an implementation of "replace_oom_score_adj"
which does not return the old value: so no, that name does not imply
that it will be returning the old value. But since it does return
something, it's quite reasonable that what it returns is the old
value.
Whereas "test_set_oom_score_adj" tends to imply that it will set the
oom_score_adj only if it's currently zero.
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-04-16 1:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 18:33 [patch] oom: replace PF_OOM_ORIGIN with toggling oom_score_adj David Rientjes
2011-04-14 0:03 ` KOSAKI Motohiro
2011-04-14 0:41 ` [patch v2] " David Rientjes
2011-04-14 0:46 ` KOSAKI Motohiro
2011-04-14 1:09 ` Minchan Kim
2011-04-14 1:12 ` David Rientjes
2011-04-14 1:21 ` Minchan Kim
2011-04-14 7:55 ` Matt Fleming
2011-04-14 20:18 ` [patch v3] " David Rientjes
2011-04-15 22:35 ` Hugh Dickins
2011-04-15 23:03 ` David Rientjes
2011-04-16 1:48 ` Hugh Dickins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=BD0PRHPGqmc1KrxwX2cyPdjSc5w@mail.gmail.com' \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=matt@console-pimps.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.