All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier.adi@gmail.com>
To: Arun Sharma <asharma@fb.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
	David Miller <davem@davemloft.net>, Andrew Morton <akpm@osdl.org>,
	Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH 2/2] atomic: move atomic_add_unless to generic code
Date: Tue, 31 May 2011 16:21:12 -0400	[thread overview]
Message-ID: <BANLkTi=Tg=t5LrnvR2Sn08K0Ktm8ZKNCCA@mail.gmail.com> (raw)
In-Reply-To: <1306869046-20172-2-git-send-email-asharma@fb.com>

On Tue, May 31, 2011 at 15:10, Arun Sharma wrote:
> This is in preparation for more generic atomic
> primitives based on __atomic_add_unless.

i think you might have to have those primitives in place before this
patch makes sense.  the only thing this does is hoist a single
comparison out of arch atomic.h's and into linux/atomic.h.  this
savings alone looks simply like over engineering to me.
-mike

  reply	other threads:[~2011-05-31 20:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-31 19:10 [PATCH 1/2] atomic: use <linux/atomic.h> Arun Sharma
2011-05-31 19:10 ` [PATCH 2/2] atomic: move atomic_add_unless to generic code Arun Sharma
2011-05-31 20:21   ` Mike Frysinger [this message]
2011-05-31 21:17     ` Arun Sharma
2011-06-02 14:53       ` Mike Frysinger
2011-06-02 17:23         ` Arun Sharma
2011-06-07 23:48           ` Andrew Morton
2011-06-08  0:42             ` Arun Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTi=Tg=t5LrnvR2Sn08K0Ktm8ZKNCCA@mail.gmail.com' \
    --to=vapier.adi@gmail.com \
    --cc=akpm@osdl.org \
    --cc=asharma@fb.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.