From: Thomas De Schampheleire <patrickdepinguin+linuxppc@gmail.com>
To: Timur Tabi <timur@freescale.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>
Subject: Re: Mapping an executable page
Date: Wed, 22 Jun 2011 09:44:28 +0200 [thread overview]
Message-ID: <BANLkTi=iqT6_8XW7hNCn-Ezd0RfcEcfucQ@mail.gmail.com> (raw)
In-Reply-To: <4DF7BE43.1010407@freescale.com>
On Tue, Jun 14, 2011 at 10:02 PM, Timur Tabi <timur@freescale.com> wrote:
> Thomas De Schampheleire wrote:
>
>> * However, if you jump to an address in that page, you'll have to make
>> sure that the entire code that executes is mapped (make map_size large
>> enough).
>
> Well, that seems obvious.
Agreed.
>
>> * When that range spanned multiple pages, I faced the issue of only
>> one page being actually mapped in the TLBs. My assumption is that the
>> call to __ioremap not necessarily updates the TLBs, but mainly some
>> kernel-internal tables. The actual TLB mapping presumably happens when
>> a data exception occurs.
>
> Hmmm.... I find that surprising. =A0Memory allocated via ioremap() is sup=
posed to
> be available in interrupt handlers, where TLB mappings can't be created
> on-the-fly. =A0I'm not sure that your observation is correct.
>
>> * Therefore, to make sure that the mapping I intended with __ioremap()
>> is actually reflected in the TLB tables, I added dummy reads of each
>> page in the TLB, prior to jumping to the boot code, as follows:
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 /* make sure memory is read, once every =
4Kbyte is enough */
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 for (p =3D vaddr; p < vaddr + map_size; =
p +=3D 0x1000) {
>
> You should at least use PAGE_SIZE instead of 0x1000.
Thanks, I fixed this.
Thomas
next prev parent reply other threads:[~2011-06-22 7:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-27 13:25 Mapping an executable page Thomas De Schampheleire
2011-05-29 14:53 ` Tabi Timur-B04825
2011-06-14 8:56 ` Thomas De Schampheleire
2011-06-14 20:02 ` Timur Tabi
2011-06-14 20:07 ` Timur Tabi
2011-06-22 7:49 ` Thomas De Schampheleire
2011-06-22 11:40 ` Tabi Timur-B04825
2011-06-22 12:53 ` Thomas De Schampheleire
2011-06-22 7:44 ` Thomas De Schampheleire [this message]
2011-06-14 20:26 ` Scott Wood
2011-06-22 7:52 ` Thomas De Schampheleire
2011-05-31 16:01 ` McClintock Matthew-B29882
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=iqT6_8XW7hNCn-Ezd0RfcEcfucQ@mail.gmail.com' \
--to=patrickdepinguin+linuxppc@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.