From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755780Ab1FVJin (ORCPT ); Wed, 22 Jun 2011 05:38:43 -0400 Received: from mail-qy0-f174.google.com ([209.85.216.174]:52206 "EHLO mail-qy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752707Ab1FVJim convert rfc822-to-8bit (ORCPT ); Wed, 22 Jun 2011 05:38:42 -0400 MIME-Version: 1.0 In-Reply-To: References: <1308699521-20556-1-git-send-email-per.forlin@linaro.org> <1308699521-20556-3-git-send-email-per.forlin@linaro.org> Date: Wed, 22 Jun 2011 11:38:41 +0200 Message-ID: Subject: Re: [PATCH v7 02/11] omap_hsmmc: add support for pre_req and post_req From: Per Forlin To: Nickolay Nickolaev Cc: linaro-dev@lists.linaro.org, Nicolas Pitre , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, Venkatraman S Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22 June 2011 11:31, Per Forlin wrote: > On 22 June 2011 10:51, Nickolay Nickolaev wrote: >> Hello, >> >> this one's causing me compilation trouble troubles when CONFIG_DMA_ENGINE is >> not defined. >> > I don't see this issue when I compile the kernel for a Pandaboard > without CONFIG_DMA_ENGINE being set. Could you please clarify or show > me your build log? > I don't see how host->next_data.cookie is connected to DMA_ENGINE. > I think you are referring to the mmci-patch. I'll fix the issue in mmci. >> On Wed, Jun 22, 2011 at 2:38 AM, Per Forlin wrote: >>> >>> @@ -2077,6 +2155,7 @@ static int __init omap_hsmmc_probe(struct >>> platform_device *pdev) >>>        host->mapbase   = res->start; >>>        host->base      = ioremap(host->mapbase, SZ_4K); >>>        host->power_mode = MMC_POWER_OFF; >>> +       host->next_data.cookie = 1; >>> >>>        platform_set_drvdata(pdev, host); >>>        INIT_WORK(&host->mmc_carddetect_work, omap_hsmmc_detect); >>> -- >>> 1.7.4.1 >>> >>> >> >> Maybe we can wrap it in a function as the others. >> >> regards, >> Nikolay Nikolaev >> > > Regards, > Per > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Per Forlin Subject: Re: [PATCH v7 02/11] omap_hsmmc: add support for pre_req and post_req Date: Wed, 22 Jun 2011 11:38:41 +0200 Message-ID: References: <1308699521-20556-1-git-send-email-per.forlin@linaro.org> <1308699521-20556-3-git-send-email-per.forlin@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linaro-dev-bounces-cunTk1MwBs8s++Sfvej+rw@public.gmane.org Errors-To: linaro-dev-bounces-cunTk1MwBs8s++Sfvej+rw@public.gmane.org To: Nickolay Nickolaev Cc: Nicolas Pitre , linaro-dev-cunTk1MwBs8s++Sfvej+rw@public.gmane.org, linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-mmc@vger.kernel.org On 22 June 2011 11:31, Per Forlin wrote: > On 22 June 2011 10:51, Nickolay Nickolaev wrote: >> Hello, >> >> this one's causing me compilation trouble troubles when CONFIG_DMA_ENGIN= E is >> not defined. >> > I don't see this issue when I compile the kernel for a Pandaboard > without CONFIG_DMA_ENGINE being set. Could you please clarify or show > me your build log? > I don't see how host->next_data.cookie is connected to DMA_ENGINE. > I think you are referring to the mmci-patch. I'll fix the issue in mmci. >> On Wed, Jun 22, 2011 at 2:38 AM, Per Forlin wrot= e: >>> >>> @@ -2077,6 +2155,7 @@ static int __init omap_hsmmc_probe(struct >>> platform_device *pdev) >>> =A0 =A0 =A0 =A0host->mapbase =A0 =3D res->start; >>> =A0 =A0 =A0 =A0host->base =A0 =A0 =A0=3D ioremap(host->mapbase, SZ_4K); >>> =A0 =A0 =A0 =A0host->power_mode =3D MMC_POWER_OFF; >>> + =A0 =A0 =A0 host->next_data.cookie =3D 1; >>> >>> =A0 =A0 =A0 =A0platform_set_drvdata(pdev, host); >>> =A0 =A0 =A0 =A0INIT_WORK(&host->mmc_carddetect_work, omap_hsmmc_detect); >>> -- >>> 1.7.4.1 >>> >>> >> >> Maybe we can wrap it in a function as the others. >> >> regards, >> Nikolay Nikolaev >> > > Regards, > Per > From mboxrd@z Thu Jan 1 00:00:00 1970 From: per.forlin@linaro.org (Per Forlin) Date: Wed, 22 Jun 2011 11:38:41 +0200 Subject: [PATCH v7 02/11] omap_hsmmc: add support for pre_req and post_req In-Reply-To: References: <1308699521-20556-1-git-send-email-per.forlin@linaro.org> <1308699521-20556-3-git-send-email-per.forlin@linaro.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 22 June 2011 11:31, Per Forlin wrote: > On 22 June 2011 10:51, Nickolay Nickolaev wrote: >> Hello, >> >> this one's causing me compilation trouble troubles when CONFIG_DMA_ENGINE is >> not defined. >> > I don't see this issue when I compile the kernel for a Pandaboard > without CONFIG_DMA_ENGINE being set. Could you please clarify or show > me your build log? > I don't see how host->next_data.cookie is connected to DMA_ENGINE. > I think you are referring to the mmci-patch. I'll fix the issue in mmci. >> On Wed, Jun 22, 2011 at 2:38 AM, Per Forlin wrote: >>> >>> @@ -2077,6 +2155,7 @@ static int __init omap_hsmmc_probe(struct >>> platform_device *pdev) >>> ? ? ? ?host->mapbase ? = res->start; >>> ? ? ? ?host->base ? ? ?= ioremap(host->mapbase, SZ_4K); >>> ? ? ? ?host->power_mode = MMC_POWER_OFF; >>> + ? ? ? host->next_data.cookie = 1; >>> >>> ? ? ? ?platform_set_drvdata(pdev, host); >>> ? ? ? ?INIT_WORK(&host->mmc_carddetect_work, omap_hsmmc_detect); >>> -- >>> 1.7.4.1 >>> >>> >> >> Maybe we can wrap it in a function as the others. >> >> regards, >> Nikolay Nikolaev >> > > Regards, > Per >